From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM To: Chang, Abner ,devel@edk2.groups.io From: "Arun K" X-Originating-Location: Bengaluru, Karnataka, IN (14.98.237.30) X-Originating-Platform: Windows Chrome 114 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Tue, 20 Jun 2023 23:38:40 -0700 References: In-Reply-To: Message-ID: <17916.1687329520328171515@groups.io> Content-Type: multipart/alternative; boundary="CBnlhpXiRm8hgkB6ooTE" --CBnlhpXiRm8hgkB6ooTE Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Isaac, Seems Uncrustify has not done this for=C2=A0IpmiFeaturePkg. Do I need to pr= ovide the changes for the complete IpmiFeaturePkg or for my changes alone f= ine? Sure, I will use the PCD directly instead of macros. the main concern of #i= f is to avoid compiler warnings when the library is not mapped for the disa= bled interfaces. so, can we proceed with #if logic? Please let me know your comments on this. Thanks, Arun --CBnlhpXiRm8hgkB6ooTE Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Isaac,

   Seems Uncrustify has not done this for&nb= sp;IpmiFeaturePkg. Do I need to provide the changes for the complete IpmiFe= aturePkg or for my changes alone fine?

  Sure, I will use t= he PCD directly instead of macros. the main concern of #if is to avoid comp= iler warnings when the library is not mapped for the disabled interfaces. s= o, can we proceed with #if logic? 
  Please let me know your= comments on this.

Thanks,
Arun --CBnlhpXiRm8hgkB6ooTE--