From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 01/10] DynamicTablesPkg: Extract AcpiTableHelperLib from TableHelperLib To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Great Shelford, England, GB (217.140.106.53) X-Originating-Platform: Windows Firefox 92 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 22 Sep 2021 08:15:30 -0700 References: <20210623110525.6171-2-Pierre.Gondois@arm.com> In-Reply-To: <20210623110525.6171-2-Pierre.Gondois@arm.com> Message-ID: <17971.1632323730292070729@groups.io> Content-Type: multipart/alternative; boundary="XMx60teGkzBOnSIcWSMg" --XMx60teGkzBOnSIcWSMg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thank you for this patch. On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote: >=20 > To allow using these generic functions without including > DynamicTablesPkg definitions, move them to a new AcpiTableHelperLib > library. I think you mean AcpiHelperLib not AcpiTableHelperLib here, right? With that changed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar --XMx60teGkzBOnSIcWSMg Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

Thank you for this patch.

On Wed, Jun 23, = 2021 at 04:05 AM, PierreGondois wrote:
To allow using these generic functions without including
D= ynamicTablesPkg definitions, move them to a new AcpiTableHelperLib
lib= rary.
I think you mean AcpiHelperLib not AcpiTableHelperLib here, right?
With that changed,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.c= om>

Regards,

Sami Mujawar --XMx60teGkzBOnSIcWSMg--