From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 44AC1740053 for ; Tue, 7 Nov 2023 10:29:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oLVJcVu4Qn8W7K833W9unmAygGVM+yGpowdPsE8czdg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699352988; v=1; b=OkNOSrJBpo7+NfF+Vv6FtmdrgFD/gYvn4fes6nlto6P2RRNVzKAIGjWECJYw3Ak4HnKjyysC n5OWf/WJlIPnxFDo5qsb6ippsvl1EKtM9OhFfGHXJfIaGlC4FC7BXWc3q1Ju9rWYkkrKEuIg0SU 6Xb5RBJ74330uNcb36CeCIf4= X-Received: by 127.0.0.2 with SMTP id LgJOYY7687511x2UPkZd22zD; Tue, 07 Nov 2023 02:29:48 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7528.1699352988124919779 for ; Tue, 07 Nov 2023 02:29:48 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-UxfnV14gPwyzqlCsLMXlJw-1; Tue, 07 Nov 2023 05:29:43 -0500 X-MC-Unique: UxfnV14gPwyzqlCsLMXlJw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A00A43C1ACF5; Tue, 7 Nov 2023 10:29:42 +0000 (UTC) X-Received: from [10.39.193.64] (unknown [10.39.193.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7813C2026D68; Tue, 7 Nov 2023 10:29:41 +0000 (UTC) Message-ID: <179c18f3-6dfa-f426-30e7-ed2bd0e17315@redhat.com> Date: Tue, 7 Nov 2023 11:29:40 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 3/7] UefiCpuPkg: Adds SmmCpuSyncLib library class From: "Laszlo Ersek" To: devel@edk2.groups.io, jiaxin.wu@intel.com Cc: Eric Dong , Ray Ni , Zeng Star , Gerd Hoffmann , Rahul Kumar References: <20231103153012.3704-1-jiaxin.wu@intel.com> <20231103153012.3704-4-jiaxin.wu@intel.com> In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IGR7Knd9rMaepVCTtqtxmUedx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OkNOSrJB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/7/23 11:26, Laszlo Ersek wrote: > Furthermore, counts of objects should be generally represented as UINTN > values, unless you have a good (explained!) reason for using a different > type. If the argument is that we need atomics for manipulating CPU counts, and that we don't want to assume wider-than-32-bit atomics, then that is a *valid* argument, but it absolutely must be documented (and then *all* CPU counts in the library class header must be UINT32 *consistently*; not mixing UINT32 with UINTN with INT32). Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110837): https://edk2.groups.io/g/devel/message/110837 Mute This Topic: https://groups.io/mt/102366300/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-