From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.7335.1585656797432687645 for ; Tue, 31 Mar 2020 05:13:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mp65bIw0; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585656796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2WQex5p7D344nWwvtcXqfrWarv76QEK7wGxWNYoW0E=; b=Mp65bIw0Gw3Bo0RDnSx0Ei2zmwPvYjZpo6wRpHXylzbhQN+w3QfhOzbxPh9JkTLb7zY7PE JHvY/I1jbVixxT3QwxH8G324pwXdULe/UMSEZZcnY7AZ93TdoopA6GmKuBPrvxs1jH9sAc p35sCrD/hHfJvruNUCePYQobU9qfKK4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-JqRMcGRHNMCiQn3XVzwe5Q-1; Tue, 31 Mar 2020 08:13:12 -0400 X-MC-Unique: JqRMcGRHNMCiQn3XVzwe5Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1241C477; Tue, 31 Mar 2020 12:13:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-131.ams2.redhat.com [10.36.115.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B61096F85; Tue, 31 Mar 2020 12:13:10 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg To: Ard Biesheuvel Cc: edk2-devel-groups-io , Sean Brogan References: <23240.1585588272916499438@groups.io> <593a3ebf-bf0b-5c69-69b4-04e652e2ebf8@redhat.com> From: "Laszlo Ersek" Message-ID: <17a5f1c0-d636-7aa4-fe0d-2b9946b93f4c@redhat.com> Date: Tue, 31 Mar 2020 14:13:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 03/30/20 23:22, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 22:56, Laszlo Ersek wrote: >> >> On 03/30/20 19:44, Ard Biesheuvel wrote: >>> On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io >>> wrote: >>>> >>>> On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: >>>> >>>> Is there any way I could contribute ArmVirtQemu to this? Or would it >>>> be easier if I provided comments/instructions? >>>> >>>> Either way. >>>> Any instructions you provide would be great. I was going to hack something up for feedback but happy for someone else to do it. Let me know. >>> >>> OK, so the typical invocation would be >>> >>> qemu-system-aarch64 -M virt -cpu cortex-a57 -m 1024 -net none >>> -nographic -bios .../path/to/QEMU_EFI.fd -hda >>> fat:rw:.../path/to/startup.nsh >>> >>> The only complication compared to OVMF is that there is no separate >>> serial port for debug output vs console output, so everything is going >>> to come out of the same pipe, and grep'ing the console output for >>> meaningful strings may easily result in false positives. (-pflash >>> could be used as well, but doesn't really add anything in this case, >>> and QEMU for ARM has a quirk where pflash images must be exactly 64 MB >>> in size) >> >> I'm begging you not to introduce instances of "-bios" anywhere near >> edk2. Please? :) We need to educate QEMU users, and we need to keep our >> sanity when facing bug reports. Let's not set bad examples anywhere, if >> we can manage. >> >> I think truncate(1) can do what we need for padding, without actually >> allocating those MBs. >> > > truncate should work on Linux, but I have no idea how to pad an image > to a certain size on Windows, and I think the idea was to enable both? > > In any case, I don't feel as strongly about this as Laszlo does: even > though -bios really shouldn't be used when you are actually installing > an OS into the VM, I don't think it is inappropriate for booting into > a shell and nothing else. Perhaps we could annotate the scripts in a > way that discourages people from adopting it? > > Or if there is an easy way to make this work on both Windows and Linux > using -pflash, I obviously wouldn't mind. I just don't feel it is > essential. OK, thank you. Meta-comment: while I have strong opinions about these matters, I'm 100% aware that I cannot put in basically any actual work. So I'm trying to police myself in that I make suggestions politely and really only as moderate suggestions, not as "demands" or knee-jerk reactions. Unfortunately, I sometimes slip up, and my thoughts hit the list in less than optimal form. I'm really sorry about that! It's a fine line -- I don't want to ignore this topic (esp. when asked for an opinion), but then again I shouldn't present unreasonable "requirements", without the capacity to contribute code. Please bear with me. :) Thanks! Laszlo