Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 4/22/19 3:46 PM, Wang, Jian J wrote:
> crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in inf.
> That means we need this patch for build on FreeBSD.
> 
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Commit 1a734ed85fda71630c795832e6d24ea560caf739 has weird authorship
again: rebecca via Groups.Io <rebecca=bluestop.org@groups.io>

> Jian
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> rebecca via Groups.Io
>> Sent: Sunday, April 21, 2019 1:18 AM
>> To: devel@edk2.groups.io; ard.biesheuvel@linaro.org
>> Cc: Ye, Ting <ting.ye@intel.com>; Gang Wei <gang.wei@intel.com>; Wang, Jian
>> J <jian.j.wang@intel.com>
>> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix
>> openssl build on FreeBSD
>>
>> On 2019-04-20 05:28, Ard Biesheuvel wrote:
>>>
>>> This is slightly odd. The host architecture shouldn't really matter,
>>> and so if we end up calling different code in UEFI when built on *BSD,
>>> there is differently something wrong. Or am I missing something?
>>
>>
>> No, that's a good point. I guess it's something we don't ever call.
>>
>> In fact, OVMF continues to build after removing crypto/uid.c (which
>> contains the OPENSSL_issetugid definition) from
>> CryptoPkg/Library/OpensslLib/OpensslLib.inf and
>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf .
>>
>>
>> --
>>
>> Rebecca Cran