From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.66, mailfrom: philmd@redhat.com) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Wed, 24 Apr 2019 02:25:11 -0700 Received: by mail-wm1-f66.google.com with SMTP id n25so3982489wmk.4 for ; Wed, 24 Apr 2019 02:25:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5bheDFZFyYxs1UQFN88XRRbJe7xfmVSQm8d+qkW5oQM=; b=R2CrMHdMWbQW2ejvwGR43uK1FptDgLKUci431UzgwvWxXjR3n2hAo8YfIiUdfXGGrF symyt8GcvriT9/j9dilL0S8rdPOkcb0NCr3CBnvyw1oZLTxkHL6wc+NG+Kufb6bz9LaC B2zxJnBrY5REXZmnBVQneAJODb9E3K103Y0qBWpb9VOkUExTTcVQoE7+FQkJFMH2Lcga vWaucEeZ5Sfc3nw7XvcXWzqYln6b+k95/CyD15N+KM+EGeFxUWSAsg1xX+v9Ppc2SDvB 7y2RGGNNhOBvG9JChwPNQ7u+2VjDqBOa31r6AUJbfL4zZbffhTVOzCfGx2IolXlLc9gt 3+UQ== X-Gm-Message-State: APjAAAXpbZ2X3+9sXtlq51ws9NMBBEYbbIC6KIYXqRINcmtOfZc64Nte JJpClqbntGCgZTFZkCm5S9gO9Q== X-Google-Smtp-Source: APXvYqzN6YicPufdaaJErVhk5uAfOblUePXx+6VXxg5zovtQoyk0Oe3Y8A0gPHmo+eFuqbTIEJ5f7g== X-Received: by 2002:a05:600c:211a:: with SMTP id u26mr6152401wml.74.1556097909810; Wed, 24 Apr 2019 02:25:09 -0700 (PDT) Return-Path: Received: from [192.168.1.25] (atoulouse-656-1-803-163.w86-221.abo.wanadoo.fr. [86.221.12.163]) by smtp.gmail.com with ESMTPSA id q3sm1092261wrj.24.2019.04.24.02.25.08 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 02:25:09 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD To: devel@edk2.groups.io, jian.j.wang@intel.com, "rebecca@bluestop.org" , "ard.biesheuvel@linaro.org" Cc: "Ye, Ting" References: <20190419223829.62336-1-rebecca@bluestop.org> <8544dcc5-7817-fd5a-abe1-98ee00e6400a@bluestop.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <17b0c77c-cb9c-dbef-8101-889f2351f691@redhat.com> Date: Wed, 24 Apr 2019 11:25:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/22/19 3:46 PM, Wang, Jian J wrote: > crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in inf. > That means we need this patch for build on FreeBSD. > > Reviewed-by: Jian J Wang Commit 1a734ed85fda71630c795832e6d24ea560caf739 has weird authorship again: rebecca via Groups.Io > Jian > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> rebecca via Groups.Io >> Sent: Sunday, April 21, 2019 1:18 AM >> To: devel@edk2.groups.io; ard.biesheuvel@linaro.org >> Cc: Ye, Ting ; Gang Wei ; Wang, Jian >> J >> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix >> openssl build on FreeBSD >> >> On 2019-04-20 05:28, Ard Biesheuvel wrote: >>> >>> This is slightly odd. The host architecture shouldn't really matter, >>> and so if we end up calling different code in UEFI when built on *BSD, >>> there is differently something wrong. Or am I missing something? >> >> >> No, that's a good point. I guess it's something we don't ever call. >> >> In fact, OVMF continues to build after removing crypto/uid.c (which >> contains the OPENSSL_issetugid definition) from >> CryptoPkg/Library/OpensslLib/OpensslLib.inf and >> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf . >> >> >> -- >> >> Rebecca Cran