From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.6051.1594817736086702294 for ; Wed, 15 Jul 2020 05:55:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XLS4GFNB; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594817735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4UyjB6/gOehvfx9XSKkh5VryNk/JHk3mGr2eq6pScRs=; b=XLS4GFNB19tHxu0LFuHD1vWfWfHdgYq3scQg7PLduFPFVUeQXaRRdhpgJQzPgO83m7NYOW GP3SStndBxRnIYW6uosNg/90FPB6p7/vdfhK+7UbQ5ovkbeF5dC8qPe5tXEJXyVIVZxHip xN5S0Ozn1oTz73PVjOg/ipOgzFfJ3Q4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-322-nun5k-lePPm3B2rinLsdHA-1; Wed, 15 Jul 2020 08:55:26 -0400 X-MC-Unique: nun5k-lePPm3B2rinLsdHA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64059100CD0B; Wed, 15 Jul 2020 12:55:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-3.ams2.redhat.com [10.36.114.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 552AB1024719; Wed, 15 Jul 2020 12:55:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: devel@edk2.groups.io, vladimir.olovyannikov@broadcom.com Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd References: <20200713183137.9825-1-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: <17bab469-76af-0ffc-b99c-962f4eb20010@redhat.com> Date: Wed, 15 Jul 2020 14:55:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200713183137.9825-1-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > Introduce an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command, and > uses the same UEFI Shell command line parameters. This makes it easy > integrating http into existing UEFI Shell scripts. > Note that to enable HTTP download, feature Pcd > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must > be set to TRUE. > > Signed-off-by: Vladimir Olovyannikov > Tested-By: Samer El-Haj-Mahmoud > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > --- > .../DynamicCommand/HttpDynamicCommand/Http.c | 1700 +++++++++++++++++ > .../DynamicCommand/HttpDynamicCommand/Http.h | 84 + > .../HttpDynamicCommand/Http.uni | 113 ++ > .../HttpDynamicCommand/HttpApp.c | 53 + > .../HttpDynamicCommand/HttpApp.inf | 58 + > .../HttpDynamicCommand/HttpDynamicCommand.c | 134 ++ > .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > ShellPkg/ShellPkg.dec | 1 + > ShellPkg/ShellPkg.dsc | 5 + > 10 files changed, 2216 insertions(+) > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.c > create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf This feature sounds very attractive for virtualization too. I suggest filing a BZ for collecting the various versions of the patch (or patch series) in a common spot. (Based on the size of the patch, I assume there could be multiple versions.) Once we have a BZ, it should certainly be listed under the proposed features section for the next stable release. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#proposed-features I would also like to request that you please append patches for OvmfPkg and ArmVirtPkg, for including the new command in those platforms. Similarly to how they already include: - TftpDynamicCommand.inf - LinuxInitrdDynamicShellCommand.inf Thank you! Laszlo