From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B4A00941335 for ; Thu, 15 Feb 2024 07:57:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=O6jhAQbFNxQocy27P/iDMjWVirlPuVC8rAJlhdrciSU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707983873; v=1; b=oK8fHgs7kDu2nahN/va5hRSdovi4RJgCnHJadyNRLC2tWZDPMWepLO6aFmPakcROu6SMmdk/ xxKCJ81bqzmXgxdHPIjGcPAyEvD9urV8bczbLjnz07AICZHtJjUdZ1MLvrP6rJNLv8nu6UYJvcD YUNgWCIlw/uyUu15aovodu4Y= X-Received: by 127.0.0.2 with SMTP id pQI5YY7687511xkPfu1DUibd; Wed, 14 Feb 2024 23:57:53 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.9414.1707983872554275634 for ; Wed, 14 Feb 2024 23:57:52 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-wCy4g5XLPqO-JBvEMLEbuQ-1; Thu, 15 Feb 2024 02:57:49 -0500 X-MC-Unique: wCy4g5XLPqO-JBvEMLEbuQ-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5CD2D83B86F; Thu, 15 Feb 2024 07:57:47 +0000 (UTC) X-Received: from [10.39.192.112] (unknown [10.39.192.112]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F3F0C185C0; Thu, 15 Feb 2024 07:57:38 +0000 (UTC) Message-ID: <17be8fb9-914b-d428-6db4-dcd4d108932e@redhat.com> Date: Thu, 15 Feb 2024 08:57:36 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Abdul Lateef Attar , Abner Chang , "Warkentin, Andrei" , Andrew Fish , Ard Biesheuvel , "S, Ashraf Ali" , Bibo Mao , "Feng, Bob C" , "West, Catharine" , Chao Li , "Chiu, Chasel" , "Duggapu, Chinni B" , Duke Zhai , "Aktas, Erdem" , Eric Xing , Gerd Hoffmann , "Guo, Gua" , "Dong, Guo" , Igniculus Fu , "Lu, James" , "Yao, Jiewen" , Kelly Steele , Ken Yao , Leif Lindholm , Liming Gao , Michael Roth , "Xu, Min M" , "Desimone, Nathaniel L" , Paul Grimes , "Kumar, Rahul R" , "Ni, Ray" , Rebecca Cran , "Chaganty, Rangasai V" , Sami Mujawar , "Rhodes, Sean" , "Zeng, Star" , Sunil V L , "Mohapatra, Susovan" , "Kuo, Ted" , Tom Lendacky , USER0FISH , Xianglai li , "Chen, Christine" , caiyuqing379 , dahogn , meng-cz References: <36593e23-d3e8-b71a-808d-ef94260b5fd0@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DDbNaWZXdNsypgr9snteEOwxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oK8fHgs7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/8/24 17:40, Michael D Kinney wrote: > Hi Laszlo, >=20 > I need to review the proposed BaseTools/AutoGen change to see what option= s > are available for compatibility. >=20 > My main concern is downstream consumers that may break immediately with > a change like this and we need a way for them to be informed and have > time to update their components just like you outline a sequence to updat= e > the edk2 repo components. Should AutoGen declare ProcessLibraryConstructorList() for a SEC module if INF_VERSION >=3D 1.30? Or should we introduce a new macro in [Defines]? https://tianocore-docs.github.io/edk2-InfSpecification/draft/2_inf_overview= /24_[defines]_section.html "EDK II parsing utilities will use some of this section's information for generating AutoGen.c and AutoGen.h files." I'd prefer (INF_VERSION >=3D 1.30) over a dedicated macro. We should ensure, over time, that ProcessLibraryConstructorList() is declared by default, for SEC modules. If that declaration depended on an explicit new macro in [Defines], it would much less likely become the default. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115491): https://edk2.groups.io/g/devel/message/115491 Mute This Topic: https://groups.io/mt/104210524/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-