From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 228C821121200
 for <edk2-devel@lists.01.org>; Thu,  6 Sep 2018 05:24:47 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
 [10.11.54.6])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 552D1804B9F4;
 Thu,  6 Sep 2018 12:24:46 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-62.rdu2.redhat.com
 [10.10.120.62])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 5323B2166B41;
 Thu,  6 Sep 2018 12:24:45 +0000 (UTC)
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jim.Dailey@dell.com, "Carsey, Jaben" <jaben.carsey@intel.com>,
 Ruiyu Ni <ruiyu.ni@intel.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
References: <20180809054155.30244-1-shenglei.zhang@intel.com>
 <809ce67145704edeb41da02b7e5bdce5@ausx13mps335.AMER.DELL.COM>
 <CAKv+Gu-2=nnC8VXokpK_kRO3H6AN=C3XAZ=fquVK3ZxtmR685A@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <17d57db5-c15a-b71b-3d82-39aaad39ece2@redhat.com>
Date: Thu, 6 Sep 2018 14:24:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu-2=nnC8VXokpK_kRO3H6AN=C3XAZ=fquVK3ZxtmR685A@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.8]); Thu, 06 Sep 2018 12:24:46 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]);
 Thu, 06 Sep 2018 12:24:46 +0000 (UTC) for IP:'10.11.54.6'
 DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH] ShellPkg Shell: Remove redundant functions
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 12:24:47 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 09/06/18 12:28, Ard Biesheuvel wrote:
> On 9 August 2018 at 17:41,  <Jim.Dailey@dell.com> wrote:
>> The InvalidChars[] array is only used in function IsValidCommandName().
>> The array should be deleted also, I think.
>>
> 
> Indeed, and for this reason this patch has now broken the build for
> clang. Please fix.

I agree about InvalidChars being unused, post-22cf747fcf75. I just can't
reproduce the build error, with CLANG38 (3.8.1). The command

  build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \
    -m ShellPkg/Application/Shell/Shell.inf

seems to work for me, also with "-b DEBUG".

What differs on your end?

Thanks,
Laszlo