Re: [edk2-platforms][PATCH V2 14/14] ManageabilityPkg: Add Manageability FDFs

["Tinh Nguyen" <tinhnguyen@os.amperecomputing.com>]

Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>

On 18/04/2023 14:15, abner.chang@amd.com wrote:
> From: Abner Chang <abner.chang@amd.com>
>
> Add FDF include files for build in ManageabilityPkg
> modules to firmware device.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> ---
>   .../ManageabilityPkg/Include/PostMemory.fdf   | 28 +++++++++++++++++++
>   .../ManageabilityPkg/Include/PreMemory.fdf    | 12 ++++++++
>   2 files changed, 40 insertions(+)
>   create mode 100644 Features/ManageabilityPkg/Include/PostMemory.fdf
>   create mode 100644 Features/ManageabilityPkg/Include/PreMemory.fdf
>
> diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf b/Features/ManageabilityPkg/Include/PostMemory.fdf
> new file mode 100644
> index 0000000000..9100cb2646
> --- /dev/null
> +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf
> @@ -0,0 +1,28 @@
> +## @file
> +# Manageabilty Package post memory initialization firmware
> +# volume description.
> +#
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable == TRUE
> +  INF ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
> +!endif
> +
> +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable == TRUE
> +  INF ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
> +!endif
> +
> +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable == TRUE
> +  INF ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.inf
> +!endif
> +
> +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable == TRUE
> +  INF ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.inf
> +!endif
> +
> +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE
> +  INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf
> +!endif
> diff --git a/Features/ManageabilityPkg/Include/PreMemory.fdf b/Features/ManageabilityPkg/Include/PreMemory.fdf
> new file mode 100644
> index 0000000000..16e079f494
> --- /dev/null
> +++ b/Features/ManageabilityPkg/Include/PreMemory.fdf
> @@ -0,0 +1,12 @@
> +## @file
> +# Manageabilty Package pre-memory initialization firmware
> +# volume description.
> +#
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable == TRUE
> +  INF  ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
> +!endif