From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.108]) by mx.groups.io with SMTP id smtpd.web10.1511.1681968590534977943 for ; Wed, 19 Apr 2023 22:29:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=ohU63QUd; spf=pass (domain: os.amperecomputing.com, ip: 40.107.93.108, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KhNwS1/DdRO3FlOcsGNfEFxMkGkbet0y4l80L8K+0hA1RUmjThdZedJMyPOk40bh8K4QvAMguctot6X3zZA0yCrPsH5WRm5elP0jEf4eno/+2WgO2nLFyq4o/AJBzRTKylDfRoyVDLTwKMFqtwZrs541Gw4aHQUUAczUCQax137ciIbGYBOpkig1DDwnX/Ys8Pip+nY+jHhajcWi1PrH7JntoVkfGh5y2Lmc53hd8eekirKvnSwA7K5TzOeCc81NEtWzu0PJrBCziPVJpGVQntcJsGwH0L4ypkTwjtyg+FOaLE1dnj2n9JDHz60rKMs947m28MI5l8pkkVmokLd9Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mcMDI6qcym270Y4clVQbXjrnHRMCAxHzn60zRG2aqB8=; b=dRKmQKBpldCJE5KJiLqwYAdqJnEm664S9gG5vAXPNQZoyMdQoScBhAm0q7ElWQl6XRyzTVUhWAXBtzQbGhUqKMKmklPGKhG4DTfcSg0KpHG8a8IZD9EWL6gje76hkyIjSDaTnxF5ejYr63aKKOSCW9GKhu7M3SFs/a/OnQt7mBUPBrH7eB8So00mp3Qd7/N9ndlFY7RCOuMWT5OrYpstJoxTG/0UNkiHCO1TMG1NE6UrdDwoD8ZQOsV71yO/S4PiwTdiw7eSwiEQN7MVsNpvp2GIStnMc4Mi3XrJ5uurBEirpJkKvF7KnSCSpxQLaDzaYIpDbRe+gvc276YxVBWtag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mcMDI6qcym270Y4clVQbXjrnHRMCAxHzn60zRG2aqB8=; b=ohU63QUdjUdDj24bbNElgSTQCzkmVUmjnig1dQn/AKdoempty8XiU5t2nQGtvZDX9FZbMtLvMPsUztfbm9cmyA049F6BD658cycMqI8w6coQwM9eUXzSuRGuVYUGkA28DfAeIIq+WwdQ+DHqIdxNEhsD76aQFeYxbJpEHn874lc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by CH0PR01MB7138.prod.exchangelabs.com (2603:10b6:610:eb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr 2023 05:29:48 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2%6]) with mapi id 15.20.6319.020; Thu, 20 Apr 2023 05:29:48 +0000 Message-ID: <17e30620-cd0e-1e16-0014-c78326a060e9@amperemail.onmicrosoft.com> Date: Thu, 20 Apr 2023 12:29:38 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-platforms][PATCH V2 14/14] ManageabilityPkg: Add Manageability FDFs To: abner.chang@amd.com, devel@edk2.groups.io Cc: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy , Tinh Nguyen References: <20230418071543.1951-1-abner.chang@amd.com> <20230418071543.1951-15-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230418071543.1951-15-abner.chang@amd.com> X-ClientProxiedBy: SI2PR02CA0040.apcprd02.prod.outlook.com (2603:1096:4:196::6) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|CH0PR01MB7138:EE_ X-MS-Office365-Filtering-Correlation-Id: a8ba1c1c-66a3-433e-6be6-08db416041fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Sw3Nf3xyy1iXSdb/EjGq5Qyr7qhl/UHrDmYOx6am2lgQTqD5S+2Eo/vExi1T1sk7KQIH4ZBszdo4J9gRR3NooREFsc1bxeBEmf5earTghY5folVGz5msZwrPmcJOeRA6AnB6ntxCDEOOtDj6M5DcfM5iXU0dXnHrAojujqqEhQ/qDzVqVYeLZZ9pMGgnlFAuQDC7Vbvkig3udnjS6eBqc/EmYSVjsYDdXmd+zsA+WWr8nDJzGl02dUwlAtovHHG/ox/vxr61EVZLWRLE7AotHn1WFFVnL84VGf81rm5XG3WlwjgWvXCajbjBff+pCJ+ka0JVoz1u69Erlb8ePBEKhgJEU9qSX0YV3Oy1PeoImYnkOy9PWVIiKqGNER6OavZ6qbIweuZ6o+WMhzb/JA9Qe59KFuM/uJMZMzOn5zMNumc65G0T70bPE7nEDud9/yvxikDWruJ6ROa8EJx8f/MlnaHAgWEoP6jqQtMKR87+/S0D0iUc1zEkK5BE8pl18YgyZ0rHHf/VSyKhdo/fuG/DO6vBf2oqYRwjwFBXegToBcAvKKwuJOEq8vPvrOx29RCGqpvlt+x8mvUBqAXGMJ+tCGHyIRiChjh+1N4I2/OH4t0OVnZg7sa1O4nBU4SDLOuo7a/dMEdN8GkS4MLjWzirQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(346002)(39850400004)(396003)(376002)(451199021)(83170400001)(38100700002)(38350700002)(31696002)(6486002)(478600001)(6666004)(52116002)(6512007)(26005)(6506007)(53546011)(186003)(107886003)(5660300002)(8936002)(2906002)(316002)(54906003)(31686004)(41300700001)(4326008)(66946007)(66556008)(66476007)(8676002)(2616005)(42882007)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TStZMG5yWFBTSWFZQWtBbWlWbTNQcmh6UWI0QkY1NDdsUlA0U2t4REY1dmpH?= =?utf-8?B?eUp3TmV3YkxtbDRINXpKWHN0dU5HZWxwdUNHTEllbEczc3B4elRQOVBaUDJO?= =?utf-8?B?clA1cHZTbklCRWZPdzBMQWZ6S1pDaVUvbko5Ymx3YzhKQ2M2eTcvTjdER281?= =?utf-8?B?cmNqUmZvSjBSb1NmNXU5TC9sMEpTeGNUZVQ4K3VRVWJ4ZlU5MlJPdng2Ky82?= =?utf-8?B?emxYTmlidG1WSTd2TFVrekk0SW1FNjNtNWNocXVadlhxN3pqMTNCeTlaTENK?= =?utf-8?B?RTFSb3hkSm9hbjFSZzQ2RHVSYmVGYkVzeDRoaUJJbGN4UFA1VENOYXhMTnVU?= =?utf-8?B?anMvbzhlNXp6ZjZJcEZGWklNNWl5Q1R2NUNtV0FHMlhyQnNJTnE0YUhBbDZN?= =?utf-8?B?a0xBbEZlTHBaaDlCcmQyT0cxeFJQaTlVMmRCSjNhdTJjMUplVGF6VEFxQzdI?= =?utf-8?B?bzlWWUVLUU9aSFVnSnpoU2lQNFVjNmpVeHpobXBLRzczMXJtckdOK0dmeDdP?= =?utf-8?B?dE52T0xCTjAvU1F0Q3Fud0VBVis5ZjU5MUVHeUhkVHQ0Ni9lRThYYk4rc0s5?= =?utf-8?B?UUZiYkJKb2NyRzVFVXdkWXQ3UG5ZcXZUS0tuOHZoOUtGOWM0TnlHZUdjUTM3?= =?utf-8?B?ak9ZSkNMbEJMcnZMWFRUK1ByVyswQzVSOWpTNjk4RkcvMTg1M2QzdXRRdWhC?= =?utf-8?B?d2o1ZXNGbXZ2R3MxenBoVGcvc0NDMlNhY0syZHh3OGY5K0NUQm1sL0hrYnF4?= =?utf-8?B?VExMNHhDQmhDeGFqdW1KUDAyV0RtWStROE5oVlc3cjVyMUlCbDI3M1lGRVdi?= =?utf-8?B?NEl4K1VxMDB3U2lKeExFS3hLeEtVNnVjckxHWGI1MG8wWnZGbWdMWWdiVkdw?= =?utf-8?B?amJabUp0Vm9JUTFCQ0JVQXhzbHBPQW51dmFaM2MrTGFBaVp4N01PTXdBdGRH?= =?utf-8?B?NFZKUUlFdkU4NUx0eFIzTS96elowbndkMHA0emtycTgvOGQ1ZWdiN2Z0UlVk?= =?utf-8?B?QlV2ZFlNb0xVTEVkb2Z1Tyt0QWVLNjYwTll6WUpGcFJWT0xzaE94MG9jV1E0?= =?utf-8?B?R3p3OHZqZDhIZnVTN2NDblBLY2FoVkM4NG9TNERKdEU5Y1I4NkloR0NWZlJq?= =?utf-8?B?OU1JMXM5V2FEZnAxSGNTVVRrUVFXbGxXN0xWQVZYbXVsWWtGM1ZOMlAzUFFw?= =?utf-8?B?alI4MmhkUU9yOVYzdTMrUXBQQWhrWHBvSXNUdEJmWnkxNm9yMDBQc1NUMis2?= =?utf-8?B?R0FITTJ0bDBlcTNjaDQ5RFNLa0hLVHlxL09pTm81T1dobVk4bjNHZEJPREFQ?= =?utf-8?B?SlprMCtPanU0Yit0UjhSK3poS1dBSWxCbVpxTmhOQjZOeWRwY2hkazMrN0U5?= =?utf-8?B?Nkg0VjhaaXJGMndaM05KMzRvTVlDdnkrYm5OQm5jOFRwQldJTUw1RkhQWkxG?= =?utf-8?B?aTVKbkQvVkI4L0JnTGpCb2xYWmtNdytNUDRCdmpCSExIUE1kNFhYNEpTcDQ5?= =?utf-8?B?TVo5aERnNFZGMzBWTXJuRExEVUZlT3VLbms3WjBya3BMQVRmY0lVcDRWc2Zm?= =?utf-8?B?ckZpWW1ENk1HNTB1azdEa0EzTExGckoyTFNGRWlEMlVYUkJDVHNHcFQ5RzVo?= =?utf-8?B?V3Q5UjV6Zmh4TGhrTHI2bmZ5aFBkTXQwL2UxY3pDSHd3OC9ETy8yY0NnMnBU?= =?utf-8?B?SlFjT1VHVFFVc3VIa2dnamZtTk9GVHdJRnJjaWRtUW5kN0phTVF1MzJGQ0RQ?= =?utf-8?B?NGp3NDZSMG9uTmtkeUZ5a2JsRmR2SS8wc3dyYllqN3BGZE9CTTFvbCtVMk5U?= =?utf-8?B?Si8rZ0JLQUVCTFlQd2wrMktKVUpBaTh6WmpLcEZVcHFNSDJuUXg2cjdnMFp2?= =?utf-8?B?S2cyTnp6U1dwMWhNZ3hYK1E1L0xPQTdmMUNKKzRYVEJ6K2ZLWEl1NjVnZ25G?= =?utf-8?B?QTVQcnhPVExUTE1ZM3hTWkZUZHpMYzhKS2lnQ1BkRUdXeWFQOHczdFJkMDVZ?= =?utf-8?B?eFptQjh5UlgzTWExWkNVZVA2MEowZ2V1S3psUUswVEpPZUNjdHZaNHQwWWdS?= =?utf-8?B?ZG56Q2hPTUdKcU44eXI0OTB0bmJEZ1orUytoMmtvbWtWcUU3Q2JzTmh4bWRv?= =?utf-8?B?UGkrc0tLL1pUSUxDejUzQ3pBa01qMk92SktuZno0ekR2S2pMQlVYRXRqRDZO?= =?utf-8?Q?Twy/ancMFDveVPGljYKyXivOlwAyMRrZN2gpuZXheEbc?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8ba1c1c-66a3-433e-6be6-08db416041fd X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 05:29:48.6010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bM3qmsrJh/Rv2G4YGgPFyC3NLaFw2GFMMmXmHaHq5OfMzelqZjXGwyIyzG9DEGheNGUpEPfDXNWbPHla5FYzzPb69NcALz7whopQqyM/g3O2LUjt7xDz9C1hb7I0J4kN X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB7138 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Tinh Nguyen On 18/04/2023 14:15, abner.chang@amd.com wrote: > From: Abner Chang > > Add FDF include files for build in ManageabilityPkg > modules to firmware device. > > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Tinh Nguyen > --- > .../ManageabilityPkg/Include/PostMemory.fdf | 28 +++++++++++++++++++ > .../ManageabilityPkg/Include/PreMemory.fdf | 12 ++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 Features/ManageabilityPkg/Include/PostMemory.fdf > create mode 100644 Features/ManageabilityPkg/Include/PreMemory.fdf > > diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf b/Features/ManageabilityPkg/Include/PostMemory.fdf > new file mode 100644 > index 0000000000..9100cb2646 > --- /dev/null > +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf > @@ -0,0 +1,28 @@ > +## @file > +# Manageabilty Package post memory initialization firmware > +# volume description. > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable == TRUE > + INF ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable == TRUE > + INF ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable == TRUE > + INF ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable == TRUE > + INF ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE > + INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif > diff --git a/Features/ManageabilityPkg/Include/PreMemory.fdf b/Features/ManageabilityPkg/Include/PreMemory.fdf > new file mode 100644 > index 0000000000..16e079f494 > --- /dev/null > +++ b/Features/ManageabilityPkg/Include/PreMemory.fdf > @@ -0,0 +1,12 @@ > +## @file > +# Manageabilty Package pre-memory initialization firmware > +# volume description. > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable == TRUE > + INF ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > +!endif