From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E88F211BFCC8 for ; Wed, 30 Jan 2019 08:06:22 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 08:06:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,541,1539673200"; d="scan'208";a="271179267" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 30 Jan 2019 08:06:21 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id B0388580550; Wed, 30 Jan 2019 08:06:19 -0800 (PST) Message-ID: <17ec5553ba80cd97eb33cced69602d320a9f25b4.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 17:06:17 +0100 In-Reply-To: <20181115023353.20159-9-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-9-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 08/20] IntelUndiPkg/XGigUndiDxe: add missing braces to GUID literals X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:22 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > The Data4 member of the GUID/EFI_GUID struct type is an array of > UINT8, so literals require two sets of { } braces. Add them where > missing. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 4 ++-- > IntelUndiPkg/XGigUndiDxe/StartStop.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h > b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h > index e5e669681b07..63dd841277ab 100644 > --- a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h > +++ b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h > @@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > > #define XGBE_HII_FORM_GUID \ > { \ > - 0x25fd9f0b, 0xa3ef, 0x4788, 0xa4, 0x0c, 0x81, 0x84, 0x9d, 0x17, > 0x8a, 0x6c \ > + 0x25fd9f0b, 0xa3ef, 0x4788, { 0xa4, 0x0c, 0x81, 0x84, 0x9d, > 0x17, 0x8a, 0x6c } \ > } > > #define XGBE_HII_DATA_GUID \ > { \ > - 0xe2c85968, 0x6906, 0x4b27, 0x9d, 0x09, 0x33, 0x43, 0xaf, 0x06, > 0x46, 0x76 \ > + 0xe2c85968, 0x6906, 0x4b27, { 0x9d, 0x09, 0x33, 0x43, 0xaf, > 0x06, 0x46, 0x76 } \ > } > > > diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.h > b/IntelUndiPkg/XGigUndiDxe/StartStop.h > index 03ad3dc9cecc..5dfc45c7de6a 100644 > --- a/IntelUndiPkg/XGigUndiDxe/StartStop.h > +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.h > @@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILITY OF SUCH DAMAGE. > #include "Xgbe.h" > > #define EFI_DRIVER_STOP_PROTOCOL_GUID \ > - { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ > - 0xb5, 0xfd, 0x7d, 0xc1 } > + { 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \ > + 0xb5, 0xfd, 0x7d, 0xc1 } } > > typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL; >