From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0B880AC13C6 for ; Thu, 7 Mar 2024 11:23:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qH0x7ztysy20bDbTM6Hq3ACywdLHZdmDOvMcSrba8l8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709810606; v=1; b=kly+qu0hftzYZMUV3G4yc6m8hxdPpTOumOKgwz8Z7oLM+2pAd0zggwlGFnI2yCtddD3XsCTj +PFEQlXtUJKSyyLxU6HyT/77P+mDPNvsVmOxERVgZ3Ec3TzdWjDSKLRHmY4rCEtbvDudSyjhbmc eihGta/s0u2h1Gx5Lh3qBkdVRWW63kQjwtlMs9cJarF28+SkcuYhzRa5GexWqH1Vf/MfHGuSYFY 1Cwjzy+OsCxDMawzSxdy5kBmfKXzQHAg2ZCtELBB1BShL7pLn6y/hPhQpUrFSxGTWte6m3J85J7 9p9oWhuqwXkIkwHB6sLC/kivMn6fcJICgrzBwhzC7j9bw== X-Received: by 127.0.0.2 with SMTP id 0gvzYY7687511xtPIH2umdpy; Thu, 07 Mar 2024 03:23:26 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.20880.1709810605704980329 for ; Thu, 07 Mar 2024 03:23:25 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-L-sG0wpwPBWp5rEYJCUGTA-1; Thu, 07 Mar 2024 06:23:21 -0500 X-MC-Unique: L-sG0wpwPBWp5rEYJCUGTA-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0E2829AA388; Thu, 7 Mar 2024 11:23:20 +0000 (UTC) X-Received: from [10.39.193.113] (unknown [10.39.193.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F3C937F6; Thu, 7 Mar 2024 11:23:15 +0000 (UTC) Message-ID: <17feae40-6f62-60bf-cd55-385e34f51ed0@redhat.com> Date: Thu, 07 Mar 2024 03:23:25 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again To: devel@edk2.groups.io, jlee@suse.com Cc: Liming , Michael D Kinney , joeyli.kernel@gmail.com, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com References: <20240204092914.29813-1-jlee@suse.com> <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> <20240207075549.GZ21608@linux-l9pv.suse> <17B185EB8F3EA51B.19081@groups.io> <20240304113752.GK31128@linux-l9pv.suse> <28fbbc44-cc80-e58d-f8bb-6976613dc48a@redhat.com> <20240307090426.GB31128@linux-l9pv.suse> From: "Laszlo Ersek" In-Reply-To: <20240307090426.GB31128@linux-l9pv.suse> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tEWr7Zkhl3I382J5YGQpCXtxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=kly+qu0h; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 3/7/24 10:04, joeyli via groups.io wrote: > Hi Laszlo, >=20 > On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: >> On 3/4/24 12:37, joeyli via groups.io wrote: >>> Hi, >>> >>> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: >>>> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: >>>>> Hi Laszlo, >>>>> >>>>> First, thanks for your review! >>>>> >>>>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: >>>>>> On 2/4/24 10:29, Lee, Chun-Yi wrote: >>>>>>> In case PcdFirmwareReleaseDateString is not set use a valid date >>>>>>> as fallback. But the default valid date can _NOT_ pass the Microsof= t >>>>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emit= ted >>>>>>> the error message: >>>>>>> >>>>>>> BIOS Release Date string is unexpected length: 8. This string must = be in >>>>>>> MM/DD/YYYY format. No other format is allowed and no additional inf= ormation >>>>>>> may be included. See field description in the SMBIOS specification. >>>>>>> >>>>>>> Base on SMBIOS spec v3.7.0: >>>>>>> >>>>>>> 08h 2.0+ BIOS Release Date BYTE STRING >>>>>>> String number of the BIOS release date. The date >>>>>>> string, if supplied, is in either mm/dd/yy or >>>>>>> mm/dd/yyyy format. If the year portion of the string >>>>>>> is two digits, the year is assumed to be 19yy. >>>>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS >>>>>>> version 2.3 and later. >>>>>>> >>>>>>> So, let's tweek the fallback release date again. >>>>>>> >>>>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback rel= ease date") [edk2-stable202305~327] >>>>>>> Signed-off-by: "Lee, Chun-Yi" >>>>>>> --- >>>>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPk= g/SmbiosPlatformDxe/SmbiosPlatformDxe.c >>>>>>> index 0ca3776045..e929da6b81 100644 >>>>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c >>>>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c >>>>>>> @@ -160,7 +160,7 @@ InstallAllStructures ( >>>>>>> DateStr =3D (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateSt= ring); >>>>>>> DateLen =3D StrLen (DateStr); >>>>>>> if (DateLen < 3) { >>>>>>> - DateStr =3D L"2/2/2022"; >>>>>>> + DateStr =3D L"02/02/2022"; >>>>>>> DateLen =3D StrLen (DateStr); >>>>>>> } >>>>>>> =20 >>>>>> >>>>>> Are you proposing this as an important (but low risk) bugfix that mi= ght >>>>>> qualify for the freeze(s)? If so, please loop in Liming and Mike. >>>>>> >>>>> >>>>> hm... What does freeze mean?=20 >>>>> >>>> >>>> ah... You mean soft feature freeze for edk2-stable202402.=20 >>>> >>>> Hi Liming, Michael, >>>> >>>> This change is important but low risk. Could you please consider to ad= d it >>>> to edk2-stable202402 release? >>>> >>>> Thanks a lot! >>>> Joey Lee >>> >>> This patch is not in edk2-stable202402. Will it to be merged to next re= lease? >> >> Thanks for the reminder, and sorry about the delay! >> >> Merged as commit 2a0d4a2641a7, via >> . >=20 > Thanks for your review and merge! >=20 >> >> For future contributions: please run PatchCheck.py on the patch series >> before formatting and posting it (better yet, submit a personal CI build >> PR). >> >=20 > For 'submit personal CI build PR', I was created a pull requests on githu= b: > https://github.com/tianocore/edk2/pull/5349=20 >=20 > Is it the right approach for triggering a CI build PR? Yes, it is. ... I think the enforcement of Cc: tags in commit messages may have been introduced later than your PR. New PRs like yours will catch missing Cc: tags. Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116483): https://edk2.groups.io/g/devel/message/116483 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-