[PATCH] Platform/Loongson: Allow building with stack protector support

[PATCH] Platform/Loongson: Allow building with stack protector support

[WANG Xuerui]

Some toolchains have stack protection enabled by default, so without the
appropriate library included the build will fail with missing symbols
during link.

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: WANG Xuerui <git@xen0n.name>
---
 Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
index d1162519cd..465e9229a2 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
+++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
@@ -95,6 +95,9 @@
   TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
 !endif
 
+  # For stack protector support
+  NULL                             | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+
   BaseLib                          | MdePkg/Library/BaseLib/BaseLib.inf
   SafeIntLib                       | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   TimeBaseLib                      | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
-- 
2.39.1

Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

Reviewed-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
在 2023/3/5 12:40, WANG Xuerui 写道:
> Some toolchains have stack protection enabled by default, so without the
> appropriate library included the build will fail with missing symbols
> during link.
>
> Cc: Bibo Mao<maobibo@loongson.cn>
> Cc: Xianglai li<lixianglai@loongson.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Michael D Kinney<michael.d.kinney@intel.com>
> Signed-off-by: WANG Xuerui<git@xen0n.name>
> ---
>   Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> index d1162519cd..465e9229a2 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> @@ -95,6 +95,9 @@
>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>   !endif
>   
> +  # For stack protector support
> +  NULL                             | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
>     BaseLib                          | MdePkg/Library/BaseLib/BaseLib.inf
>     SafeIntLib                       | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>     TimeBaseLib                      | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf

[-- Attachment #2: Type: text/html, Size: 2498 bytes --]

Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support

[xianglai]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

Reviewed-by: Xianglai Li <lixianglai@loongson.cn>

On 2023/3/5 下午12:40, WANG Xuerui wrote:
> Some toolchains have stack protection enabled by default, so without the
> appropriate library included the build will fail with missing symbols
> during link.
>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> ---
>   Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> index d1162519cd..465e9229a2 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> @@ -95,6 +95,9 @@
>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>   !endif
>   
> +  # For stack protector support
> +  NULL                             | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
>     BaseLib                          | MdePkg/Library/BaseLib/BaseLib.inf
>     SafeIntLib                       | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>     TimeBaseLib                      | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf

[-- Attachment #2: Type: text/html, Size: 2213 bytes --]

Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

Hi Xuerui,

I and Xianglai have reviewed this change a few days ago, you can create 
a PR in the edk2-platforms repo.


Thanks,
Chao
在 2023/3/8 11:17, xianglai 写道:
>
> Reviewed-by: Xianglai Li <lixianglai@loongson.cn>
>
> On 2023/3/5 下午12:40, WANG Xuerui wrote:
>> Some toolchains have stack protection enabled by default, so without the
>> appropriate library included the build will fail with missing symbols
>> during link.
>>
>> Cc: Bibo Mao<maobibo@loongson.cn>
>> Cc: Xianglai li<lixianglai@loongson.cn>
>> Cc: Chao Li<lichao@loongson.cn>
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Michael D Kinney<michael.d.kinney@intel.com>
>> Signed-off-by: WANG Xuerui<git@xen0n.name>
>> ---
>>   Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
>> index d1162519cd..465e9229a2 100644
>> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
>> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
>> @@ -95,6 +95,9 @@
>>     TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>>   !endif
>>   
>> +  # For stack protector support
>> +  NULL                             | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>> +
>>     BaseLib                          | MdePkg/Library/BaseLib/BaseLib.inf
>>     SafeIntLib                       | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>>     TimeBaseLib                      | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> 

[-- Attachment #2: Type: text/html, Size: 3186 bytes --]