Re: [PATCH v1 2/8] StandaloneMmPkg: Fix new typos reported

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Michael,

Thank you for fixing these issues. 

I have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 17/05/2022, 17:01, "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com> wrote:

    From: Michael Kubacki <michael.kubacki@microsoft.com>

    The SpellCheck plugin began reporting new typos that were previously
    missed. This change fixes those typos.

    Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
    Cc: Sami Mujawar <sami.mujawar@arm.com>
    Cc: Jiewen Yao <jiewen.yao@intel.com>
    Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
    Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
    ---
     StandaloneMmPkg/Core/Dependency.c         |  2 +-
     StandaloneMmPkg/Core/Dispatcher.c         | 18 +++++++++---------
     StandaloneMmPkg/Include/Guid/MmCoreData.h |  2 +-
     StandaloneMmPkg/StandaloneMmPkg.ci.yaml   |  9 +++++++++
     4 files changed, 20 insertions(+), 11 deletions(-)

    diff --git a/StandaloneMmPkg/Core/Dependency.c b/StandaloneMmPkg/Core/Dependency.c
    index 440fe3e45238..0e9c0e96a276 100644
    --- a/StandaloneMmPkg/Core/Dependency.c
    +++ b/StandaloneMmPkg/Core/Dependency.c
    @@ -38,7 +38,7 @@ BOOLEAN  *mDepexEvaluationStackPointer = NULL;
     /**
       Grow size of the Depex stack

    -  @retval EFI_SUCCESS           Stack successfully growed.
    +  @retval EFI_SUCCESS           Stack successfully grew.
       @retval EFI_OUT_OF_RESOURCES  There is not enough system memory to grow the stack.

     **/
    diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
    index b1ccba15b060..01da395be3c4 100644
    --- a/StandaloneMmPkg/Core/Dispatcher.c
    +++ b/StandaloneMmPkg/Core/Dispatcher.c
    @@ -17,7 +17,7 @@
                 and After dependencies. This is done recursively as the call to add
                 to the mScheduledQueue checks for Before Depexes and recursively
                 adds all Before Depexes. It then adds the item that was passed in
    -            and then processess the After dependencies by recursively calling
    +            and then processes the After dependencies by recursively calling
                 the routine.

       Dispatcher Rules:
    @@ -93,29 +93,29 @@ LIST_ENTRY  mScheduledQueue = INITIALIZE_LIST_HEAD_VARIABLE (mScheduledQueue);
     LIST_ENTRY  mFwVolList = INITIALIZE_LIST_HEAD_VARIABLE (mFwVolList);

     //
    -// Flag for the MM Dispacher.  TRUE if dispatcher is executing.
    +// Flag for the MM Dispatcher.  TRUE if dispatcher is executing.
     //
     BOOLEAN  gDispatcherRunning = FALSE;

     //
    -// Flag for the MM Dispacher.  TRUE if there is one or more MM drivers ready to be dispatched
    +// Flag for the MM Dispatcher.  TRUE if there is one or more MM drivers ready to be dispatched
     //
     BOOLEAN  gRequestDispatch = FALSE;

     //
     // The global variable is defined for Loading modules at fixed address feature to track the MM code
    -// memory range usage. It is a bit mapped array in which every bit indicates the correspoding
    +// memory range usage. It is a bit mapped array in which every bit indicates the corresponding
     // memory page available or not.
     //
     GLOBAL_REMOVE_IF_UNREFERENCED    UINT64  *mMmCodeMemoryRangeUsageBitMap = NULL;

     /**
       To check memory usage bit map array to figure out if the memory range in which the image will be loaded
    -  is available or not. If memory range is avaliable, the function will mark the corresponding bits to 1
    +  is available or not. If memory range is available, the function will mark the corresponding bits to 1
       which indicates the memory range is used. The function is only invoked when load modules at fixed address
       feature is enabled.

    -  @param  ImageBase                The base addres the image will be loaded at.
    +  @param  ImageBase                The base address the image will be loaded at.
       @param  ImageSize                The size of the image

       @retval EFI_SUCCESS              The memory range the image will be loaded in is available
    @@ -194,7 +194,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
       @param  ImageContext              Pointer to the image context structure that describes the PE/COFF
                                         image that needs to be examined by this function.
       @retval EFI_SUCCESS               An fixed loading address is assigned to this image by build tools .
    -  @retval EFI_NOT_FOUND             The image has no assigned fixed loadding address.
    +  @retval EFI_NOT_FOUND             The image has no assigned fixed loading address.

     **/
     EFI_STATUS
    @@ -513,7 +513,7 @@ MmPreProcessDepex (

       @param  DriverEntry           Driver to work on.

    -  @retval EFI_SUCCESS           Depex read and preprossesed
    +  @retval EFI_SUCCESS           Depex read and pre-processed
       @retval EFI_PROTOCOL_ERROR    The section extraction protocol returned an error
                                     and  Depex reading needs to be retried.
       @retval Error                 DEPEX not found.
    @@ -851,7 +851,7 @@ FvIsBeingProcessed (
       The Discovered list is never freed and contains booleans that represent the
       other possible MM driver states.

    -  @param [in]   FwVolHeader     Pointer to the formware volume header.
    +  @param [in]   FwVolHeader     Pointer to the firmware volume header.
       @param [in]   Pe32Data        Pointer to the PE data.
       @param [in]   Pe32DataSize    Size of the PE data.
       @param [in]   Depex           Pointer to the Depex info.
    diff --git a/StandaloneMmPkg/Include/Guid/MmCoreData.h b/StandaloneMmPkg/Include/Guid/MmCoreData.h
    index b8be92c6abfd..0f58f41d8060 100644
    --- a/StandaloneMmPkg/Include/Guid/MmCoreData.h
    +++ b/StandaloneMmPkg/Include/Guid/MmCoreData.h
    @@ -70,7 +70,7 @@ typedef struct {

       ///
       /// The MM Foundation Entry Point.  The MM Core fills in this field when the
    -  /// MM Core is initialized.  The MM IPL is responsbile for registering this entry
    +  /// MM Core is initialized.  The MM IPL is responsible for registering this entry
       /// point with the MM Configuration Protocol.  The MM Configuration Protocol may
       /// not be available at the time the MM IPL and MM Core are started, so the MM IPL
       /// sets up a protocol notification on the MM Configuration Protocol and registers
    diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
    index 4777532a7ede..535e269e7891 100644
    --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
    +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
    @@ -81,12 +81,21 @@
             "IgnoreFiles": [],           # use gitignore syntax to ignore errors
                                          # in matching files
             "ExtendWords": [
    +            "bootinformation",
                 "Bsymbolic",
    +            "bugbug",
    +            "combineable",
    +            "depexes",
                 "FwVol",
    +            "hoblist",
    +            "imagehandle",
    +            "interfacer",
[SAMI] I think there is a typo in https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Core/Handle.c#L350 and https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Core/StandaloneMmCore.h#L429, where "a protocol:interfacer" needs to be changed to "protocol interfaces".
[/SAMI] 
                 "mpidr",
                 "mstrict",
                 "schedulable",
                 "StandaloneMMCore",
    +            "systemtable",
    +            "uncacheable"
             ],           # words to extend to the dictionary for this package
             "IgnoreStandardPaths": [],   # Standard Plugin defined paths that
                                          # should be ignore
    -- 
    2.28.0.windows.1