public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Zenith432 <zenith432@users.sourceforge.net>
To: <edk2-devel@lists.01.org>
Subject: [PATCH 1/4] BaseTools: correct mal-typed CVfrDLGLexer::errstd
Date: Sat, 9 Dec 2017 14:41:49 +0000 (UTC)	[thread overview]
Message-ID: <1820255998.1779314.1512830509989@mail.yahoo.com> (raw)
In-Reply-To: 1820255998.1779314.1512830509989.ref@mail.yahoo.com

The member function CVfrDLGLexer::errstd is intended as an override virtual function of DLGLexerBase::errstd, but due to
mismatched prototype, it didn't override, and never got called.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith432@users.sourceforge.net>
---
 BaseTools/Source/C/VfrCompile/VfrSyntax.g | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/VfrCompile/VfrSyntax.g b/BaseTools/Source/C/VfrCompile/VfrSyntax.g
index fbd5abfa..a434eacf 100644
--- a/BaseTools/Source/C/VfrCompile/VfrSyntax.g
+++ b/BaseTools/Source/C/VfrCompile/VfrSyntax.g
@@ -42,7 +42,7 @@ class CVfrDLGLexer : public VfrLexer
 {
 public:
   CVfrDLGLexer (DLGFileInput *F) : VfrLexer (F) {};
-  INT32 errstd (char *Text)
+  void errstd (const char *Text)
   {
     printf ("unrecognized input '%s'\n", Text);
   }
-- 
2.14.3 (Apple Git-98)


           reply	other threads:[~2017-12-09 14:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1820255998.1779314.1512830509989.ref@mail.yahoo.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1820255998.1779314.1512830509989@mail.yahoo.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox