Re: [PATCH] MdePkg: resolve bug 741

[Zenith432 <zenith432@users.sourceforge.net>]

FWIW, I tried another solution by replacing the statement

VA_START (Args, Iso639Language);

with

VA_START (Args, *(int*)&Iso639Language);

in an attempt to get an lvalue with the same address-of as Iso639Language and correct sizeof the promoted argument, but clang doesn't like that either

error: second argument to 'va_start' is not the last named parameter [-Werror,-Wvarargs]

--------------------------------------------
On Sat, 12/9/17, Marvin H?user <Marvin.Haeuser@outlook.com> wrote:

 Subject: RE: [edk2] [PATCH] MdePkg: resolve bug 741
 To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
 Cc: "Zenith432" <zenith432@users.sourceforge.net>, "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>, "liming.gao@intel.com" <liming.gao@intel.com>
 Date: Saturday, December 9, 2017, 10:22 PM
 
 For code style purposes, I suggest to declare
 the first member of the language list as a third argument,
 process it, and then use it to get the following from the
 VA.
 Also, I think you forgot to CC the
 MdePkg maintainers, so I did with this mail.
 
 Regards,
 Marvin.