From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.163.184.59; helo=sonic317-48.consmr.mail.ne1.yahoo.com; envelope-from=zenith432@users.sourceforge.net; receiver=edk2-devel@lists.01.org Received: from sonic317-48.consmr.mail.ne1.yahoo.com (sonic317-48.consmr.mail.ne1.yahoo.com [66.163.184.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B1202214E32C for ; Sat, 9 Dec 2017 12:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1512852001; bh=ylpJeb6ASeooZZ1K6k7BKspuOT84NyHQnqSRGT5OJkE=; h=Date:From:Reply-To:To:Cc:Subject:References:From:Subject; b=lsvSb+CsCnMbPyDTWFfTfsFAoIKD5lg/9qhBY8f88lOObzuy8FoNU8S5Zd6kr1s7GGJWSAV21Gda4aocRkbltxNPPItwRNzH8jVHi6rWFj6fCLT/kVWxmLJQDN+U4V0mxlcICrxhAvBlYQzM72owRnHKSC27LRpBjTfxXyn7V3cTxOCcA1rN+jvCTOFyjMBink2QRHMKiR+d9PTbjNurqNoAELur5pYk5XuaafqpTb+i+z+I/FAyJd042MTN9uWo9QcUORfueeSoKYH6eiILoth2SlkYbuUEUYDq+Of79pkftcu34GOJuBpAx1C1ZfDV8MilACCJC9jfZ31hbRyOlQ== X-YMail-OSG: GAinNdMVM1n.aOdfKz.km929PEIXMscuYVj0c9050n.1htjOmwxn.3JUjvtEcEI gin.5wy2xXvs6apjqcTYpbFEhl80Z81BupMHmkeanTMCnjLXM_6WWUzqLgmN543GMEBv_8fVGiE3 GDqYoADe3YFmeTxyZL5O640XyvUyv_I_dFerZbG73uUrMzx8X2oNiRNefW8ZUpxzC.s8XNFbiDxP r0QAhFPzQ98pT.p_o.ZOmHhkSeRSLw_rKbunckF4E.liYFd2e3JhMTliycwYgu.bbflZ6c8fX_mV P3F7s8bCTj2avpG37jkI28EJY3lcqFuSNQ03rYozNkl90vCK8_BAUin2iG6STa8s9FaM6IxahCfa 0H8CYZI4GS_qvrL7QLUIEATE5kwX2_5XLAcy63PJeqMZK80H1U_C2X9slvwis4D2yikUEWCDK7yL Jj8HJPoH5Y95_iUpqiHfXKEVZuxRCcptlZFtbQPAff6OwKBAQvhEtS4icxPR61Zl7zRBZyIM.bXQ dG33WM0hpNFfkqhPEwS4ublvKa.HOyA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Sat, 9 Dec 2017 20:40:01 +0000 Date: Sat, 9 Dec 2017 20:40:00 +0000 (UTC) From: Zenith432 Reply-To: Zenith432 To: "edk2-devel@lists.01.org" , Marvin H?user Cc: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Message-ID: <1822489314.1922023.1512852000221@mail.yahoo.com> MIME-Version: 1.0 References: <1822489314.1922023.1512852000221.ref@mail.yahoo.com> X-Mailer: WebService/1.1.11051 YahooMailBasic Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/604.4.7 (KHTML, like Gecko) Version/11.0.2 Safari/604.4.7 Subject: Re: [PATCH] MdePkg: resolve bug 741 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Dec 2017 20:35:26 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit FWIW, I tried another solution by replacing the statement VA_START (Args, Iso639Language); with VA_START (Args, *(int*)&Iso639Language); in an attempt to get an lvalue with the same address-of as Iso639Language and correct sizeof the promoted argument, but clang doesn't like that either error: second argument to 'va_start' is not the last named parameter [-Werror,-Wvarargs] -------------------------------------------- On Sat, 12/9/17, Marvin H?user wrote: Subject: RE: [edk2] [PATCH] MdePkg: resolve bug 741 To: "edk2-devel@lists.01.org" Cc: "Zenith432" , "michael.d.kinney@intel.com" , "liming.gao@intel.com" Date: Saturday, December 9, 2017, 10:22 PM For code style purposes, I suggest to declare the first member of the language list as a third argument, process it, and then use it to get the following from the VA. Also, I think you forgot to CC the MdePkg maintainers, so I did with this mail. Regards, Marvin.