Re: [edk2-devel] [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles

["Laszlo Ersek" <lersek@redhat.com>]

Hi Mike,

On 04/20/19 02:17, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1734
> 
> Remove the following packages and move them to the new
> edk2-libc repository
> 
> * AppPkg
> * StdLib
> * StdLibPrivateInternalFiles
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Daryl McDaniel <edk2-lists@mc2research.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  AppPkg
>  Maintainers.txt                               |    10 -
>  Readme.md                                     |     3 -
>  StdLib
>  StdLibPrivateInternalFiles

the subject line suggests the patch is for the core edk2 repository. In
that case, I'd expect all edk2 files under AppPkg etc to be listed in
the diffstat at least (even if we -- likely justifiedly -- decide that
it makes little sense to include all the *code* that's being removed in
the patch).

If the patch is indeed for core edk2, then please see my comments in the
thread "[edk2] Request to add new edk2-libc repository".

Thanks!
Laszlo

> 
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 10c11b5dc5..a0f8d541d0 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -63,11 +63,6 @@ M: Liming Gao <liming.gao@intel.com>
>  
>  EDK II Packages:
>  ----------------
> -AppPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/AppPkg
> -M: Daryl McDaniel <edk2-lists@mc2research.org>
> -M: Jaben Carsey <jaben.carsey@intel.com>
> -
>  ArmPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPkg
>  M: Leif Lindholm <leif.lindholm@linaro.org>
> @@ -260,11 +255,6 @@ SourceLevelDebugPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SourceLevelDebugPkg
>  M: Hao Wu <hao.a.wu@intel.com>
>  
> -StdLib, StdLibPrivateInternalFiles
> -W: https://github.com/tianocore/tianocore.github.io/wiki/StdLib
> -M: Daryl McDaniel <edk2-lists@mc2research.org>
> -M: Jaben Carsey <jaben.carsey@intel.com>
> -
>  UefiCpuPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
>  M: Eric Dong <eric.dong@intel.com>
> diff --git a/Readme.md b/Readme.md
> index 177d51972a..1feba16075 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -6,9 +6,6 @@ for the UEFI and PI specifications from www.uefi.org.
>  The majority of the content in the EDK II open source project uses a
>  [BSD-2-Clause Plus Patent License](License.txt).  The EDK II open source project
>  contains the following components that are covered by additional licenses:
> -* [AppPkg/Applications/Python/Python-2.7.2/Tools/pybench](AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/LICENSE)
> -* [AppPkg/Applications/Python/Python-2.7.2](AppPkg/Applications/Python/Python-2.7.2/LICENSE)
> -* [AppPkg/Applications/Python/Python-2.7.10](AppPkg/Applications/Python/Python-2.7.10/LICENSE)
>  * [BaseTools/Source/C/BrotliCompress](BaseTools/Source/C/BrotliCompress/LICENSE)
>  * [MdeModulePkg/Library/BrotliCustomDecompressLib](MdeModulePkg/Library/BrotliCustomDecompressLib/LICENSE)
>  * [BaseTools/Source/C/LzmaCompress](BaseTools/Source/C/LzmaCompress/LZMA-SDK-README.txt)
> 
> 
>