Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Heinrich Schuchardt]

On 9/29/23 04:02, John Chew wrote:
> Update Gigadevice norflash list:
> gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256
> 
> Add Silicon Kaiser norflash list:
> sk25lp128
> 
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Li Yong <yong.li@intel.com>
> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
> ---
>   EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> index e16c1c6a14..422fdac851 100644
> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> @@ -1,6 +1,7 @@
>   /** @file
>   *
>   *  Copyright (c) 2017 Marvell International Ltd.
> +*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights reserved.<BR>
>   *
>   *  SPDX-License-Identifier: BSD-2-Clause-Patent
>   *
> @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
>     { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
>     { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>     /* GIGADEVICE */
> -  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
>     { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },

Linux calls this gd25q64 but probably we don't want to change the 
displayed name.

> +  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
> +  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },

Linux calls this gd25lq128d.

> +  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },

Except for the two labels the changes match 
drivers/mtd/spi-nor/gigadevice.c in Linux.

>     /* ISSI */
>     { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
>     { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>     { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
> +  /* XINKAI / SILICON KAISER */
> +  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },

This matches
https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/

Acked-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>


>     /* MACRONIX */
>     { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
>     { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109210): https://edk2.groups.io/g/devel/message/109210
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Heinrich Schuchardt]

On 29.09.23 15:35, YuinYee Chew wrote:
> Hi Heinrich,
> 
> Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}"
> gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html
> gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128e
> So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e".
> If sync with Linux, gd25lq128d will be better.
> 
> Do you have any suggestion on this?
> Or anyone have any opinion?
> 
> Thanks again for the feedback! =)

Thank you for the explanation.

My understanding is that these strings are for display only. So we 
should be fine with the patch as is.

Best regards

Heinrich


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109211): https://edk2.groups.io/g/devel/message/109211
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[John Chew]

Dear Maintainers,

Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.

Thank you! =)

-----Original Message-----
From: YuinYee Chew 
Sent: Friday, September 29, 2023 9:35 PM
To: 'Heinrich Schuchardt' <heinrich.schuchardt@canonical.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

Hi Heinrich,

Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}"
gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html
gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128e
So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e". 
If sync with Linux, gd25lq128d will be better.

Do you have any suggestion on this? 
Or anyone have any opinion?

Thanks again for the feedback! =)

-----Original Message-----
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sent: Friday, September 29, 2023 4:55 PM
To: YuinYee Chew <yuinyee.chew@starfivetech.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 9/29/23 04:02, John Chew wrote:
> Update Gigadevice norflash list:
> gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256
> 
> Add Silicon Kaiser norflash list:
> sk25lp128
> 
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Li Yong <yong.li@intel.com>
> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
> ---
>   EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> index e16c1c6a14..422fdac851 100644
> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> @@ -1,6 +1,7 @@
>   /** @file
>   *
>   *  Copyright (c) 2017 Marvell International Ltd.
> +*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights 
> +reserved.<BR>
>   *
>   *  SPDX-License-Identifier: BSD-2-Clause-Patent
>   *
> @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
>     { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
>     { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>     /* GIGADEVICE */
> -  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
>     { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },

Linux calls this gd25q64 but probably we don't want to change the displayed name.

> +  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> +  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
> +  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },

Linux calls this gd25lq128d.

> +  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },

Except for the two labels the changes match drivers/mtd/spi-nor/gigadevice.c in Linux.

>     /* ISSI */
>     { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
>     { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>     { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
> +  /* XINKAI / SILICON KAISER */
> +  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },

This matches
https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/

Acked-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>


>     /* MACRONIX */
>     { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
>     { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109758): https://edk2.groups.io/g/devel/message/109758
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Ard Biesheuvel]

On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
<yuinyee.chew@starfivetech.com> wrote:
>
> Dear Maintainers,
>
> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>

Thanks for the reminder. I don't have time to review this myself but
I'm happy to merge it if someone else reviews it


>
> -----Original Message-----
> From: YuinYee Chew
> Sent: Friday, September 29, 2023 9:35 PM
> To: 'Heinrich Schuchardt' <heinrich.schuchardt@canonical.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
> Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
>
> Hi Heinrich,
>
> Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}"
> gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html
> gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128e
> So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e".
> If sync with Linux, gd25lq128d will be better.
>
> Do you have any suggestion on this?
> Or anyone have any opinion?
>
> Thanks again for the feedback! =)
>
> -----Original Message-----
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Sent: Friday, September 29, 2023 4:55 PM
> To: YuinYee Chew <yuinyee.chew@starfivetech.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
> Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
>
> On 9/29/23 04:02, John Chew wrote:
> > Update Gigadevice norflash list:
> > gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256
> >
> > Add Silicon Kaiser norflash list:
> > sk25lp128
> >
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Cc: Li Yong <yong.li@intel.com>
> > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
> > ---
> >   EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > index e16c1c6a14..422fdac851 100644
> > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > @@ -1,6 +1,7 @@
> >   /** @file
> >   *
> >   *  Copyright (c) 2017 Marvell International Ltd.
> > +*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights
> > +reserved.<BR>
> >   *
> >   *  SPDX-License-Identifier: BSD-2-Clause-Patent
> >   *
> > @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
> >     { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
> >     { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
> >     /* GIGADEVICE */
> > -  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
> >     { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>
> Linux calls this gd25q64 but probably we don't want to change the displayed name.
>
> > +  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>
> Linux calls this gd25lq128d.
>
> > +  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },
>
> Except for the two labels the changes match drivers/mtd/spi-nor/gigadevice.c in Linux.
>
> >     /* ISSI */
> >     { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
> >     { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
> >     { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
> > +  /* XINKAI / SILICON KAISER */
> > +  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>
> This matches
> https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/
>
> Acked-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
>
> >     /* MACRONIX */
> >     { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
> >     { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109717): https://edk2.groups.io/g/devel/message/109717
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[John Chew]

Hi Ard

Thanks for your reply. 

I wonder if anyone have time to review this patch?

Thanks!

John

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Wednesday, October 18, 2023 4:58 PM
To: YuinYee Chew <yuinyee.chew@starfivetech.com>
Cc: devel@edk2.groups.io; Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>
Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On Wed, 18 Oct 2023 at 10:49, YuinYee Chew <yuinyee.chew@starfivetech.com> wrote:
>
> Dear Maintainers,
>
> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>

Thanks for the reminder. I don't have time to review this myself but I'm happy to merge it if someone else reviews it


>
> -----Original Message-----
> From: YuinYee Chew
> Sent: Friday, September 29, 2023 9:35 PM
> To: 'Heinrich Schuchardt' <heinrich.schuchardt@canonical.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; 
> Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel 
> <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel 
> Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
> Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash 
> device list
>
> Hi Heinrich,
>
> Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}"
> gd25lq128d : 
> https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/
> gd25lq128d.html gd25lq128e : 
> https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/
> gd25lq128e So, I'm thinking to put it as "gd25lq128" to represent both 
> "d" and "e".
> If sync with Linux, gd25lq128d will be better.
>
> Do you have any suggestion on this?
> Or anyone have any opinion?
>
> Thanks again for the feedback! =)
>
> -----Original Message-----
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Sent: Friday, September 29, 2023 4:55 PM
> To: YuinYee Chew <yuinyee.chew@starfivetech.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; 
> Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel 
> <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel 
> Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
> Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash 
> device list
>
> On 9/29/23 04:02, John Chew wrote:
> > Update Gigadevice norflash list:
> > gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256
> >
> > Add Silicon Kaiser norflash list:
> > sk25lp128
> >
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Cc: Li Yong <yong.li@intel.com>
> > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
> > ---
> >   EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > index e16c1c6a14..422fdac851 100644
> > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
> > @@ -1,6 +1,7 @@
> >   /** @file
> >   *
> >   *  Copyright (c) 2017 Marvell International Ltd.
> > +*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights 
> > +reserved.<BR>
> >   *
> >   *  SPDX-License-Identifier: BSD-2-Clause-Patent
> >   *
> > @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
> >     { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
> >     { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
> >     /* GIGADEVICE */
> > -  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
> >     { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>
> Linux calls this gd25q64 but probably we don't want to change the displayed name.
>
> > +  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
> > +  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>
> Linux calls this gd25lq128d.
>
> > +  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },
>
> Except for the two labels the changes match drivers/mtd/spi-nor/gigadevice.c in Linux.
>
> >     /* ISSI */
> >     { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
> >     { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
> >     { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
> > +  /* XINKAI / SILICON KAISER */
> > +  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>
> This matches
> https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/
>
> Acked-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
>
> >     /* MACRONIX */
> >     { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
> >     { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },
>







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109827): https://edk2.groups.io/g/devel/message/109827
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Laszlo Ersek]

On 10/18/23 10:57, Ard Biesheuvel wrote:
> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
> <yuinyee.chew@starfivetech.com> wrote:
>>
>> Dear Maintainers,
>>
>> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>>
> 
> Thanks for the reminder. I don't have time to review this myself but
> I'm happy to merge it if someone else reviews it

Heinrich gave an Acked-by up-thread.

(I'd just go ahead and merge this myself to help you out a bit, but I
don't have access to the original patch!)

Laszlo


> 
> 
>>
>> -----Original Message-----
>> From: YuinYee Chew
>> Sent: Friday, September 29, 2023 9:35 PM
>> To: 'Heinrich Schuchardt' <heinrich.schuchardt@canonical.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
>> Subject: RE: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
>>
>> Hi Heinrich,
>>
>> Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}"
>> gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html
>> gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128e
>> So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e".
>> If sync with Linux, gd25lq128d will be better.
>>
>> Do you have any suggestion on this?
>> Or anyone have any opinion?
>>
>> Thanks again for the feedback! =)
>>
>> -----Original Message-----
>> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> Sent: Friday, September 29, 2023 4:55 PM
>> To: YuinYee Chew <yuinyee.chew@starfivetech.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io
>> Subject: Re: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
>>
>> On 9/29/23 04:02, John Chew wrote:
>>> Update Gigadevice norflash list:
>>> gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256
>>>
>>> Add Silicon Kaiser norflash list:
>>> sk25lp128
>>>
>>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>>> Cc: Li Yong <yong.li@intel.com>
>>> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Abner Chang <abner.chang@amd.com>
>>> Cc: Daniel Schaefer <git@danielschaefer.me>
>>> Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
>>> ---
>>>   EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
>>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> index e16c1c6a14..422fdac851 100644
>>> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>>> @@ -1,6 +1,7 @@
>>>   /** @file
>>>   *
>>>   *  Copyright (c) 2017 Marvell International Ltd.
>>> +*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights
>>> +reserved.<BR>
>>>   *
>>>   *  SPDX-License-Identifier: BSD-2-Clause-Patent
>>>   *
>>> @@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
>>>     { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
>>>     { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>>>     /* GIGADEVICE */
>>> -  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
>>>     { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>>
>> Linux calls this gd25q64 but probably we don't want to change the displayed name.
>>
>>> +  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>>> +  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>>
>> Linux calls this gd25lq128d.
>>
>>> +  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },
>>
>> Except for the two labels the changes match drivers/mtd/spi-nor/gigadevice.c in Linux.
>>
>>>     /* ISSI */
>>>     { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
>>>     { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
>>>     { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
>>> +  /* XINKAI / SILICON KAISER */
>>> +  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
>>
>> This matches
>> https://lore.kernel.org/all/20230726214401.929533-1-jonas@kwiboo.se/
>>
>> Acked-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>>
>>
>>>     /* MACRONIX */
>>>     { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
>>>     { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },
>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109832): https://edk2.groups.io/g/devel/message/109832
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Heinrich Schuchardt]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On 20.10.23 11:49, Laszlo Ersek wrote:
> On 10/18/23 10:57, Ard Biesheuvel wrote:
>> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
>> <yuinyee.chew@starfivetech.com>  wrote:
>>> Dear Maintainers,
>>>
>>> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>>>
>> Thanks for the reminder. I don't have time to review this myself but
>> I'm happy to merge it if someone else reviews it
> Heinrich gave an Acked-by up-thread.
> 
> (I'd just go ahead and merge this myself to help you out a bit, but I
> don't have access to the original patch!)
> 
> Laszlo

See appendix.

Best regards

Heinrich


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109846): https://edk2.groups.io/g/devel/message/109846
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: [PATCH v1] EmbeddedPkg_NorFlashInfoLib: Update norflash device list - John Chew <yuinyee.chew@starfivetech.com> - 2023-09-29 0402.eml --]
[-- Type: message/rfc822, Size: 8073 bytes --]

From: John Chew <yuinyee.chew@starfivetech.com>
To: <devel@edk2.groups.io>
Cc: John Chew <yuinyee.chew@starfivetech.com>, Sunil V L <sunilvl@ventanamicro.com>, Li Yong <yong.li@intel.com>, Heinrich Schuchardt <heinrich.schuchardt@canonical.com>, Leif Lindholm <quic_llindhol@quicinc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, Abner Chang <abner.chang@amd.com>, Daniel Schaefer <git@danielschaefer.me>
Subject: [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
Date: Fri, 29 Sep 2023 10:02:22 +0800
Message-ID: <20230929020222.2010-1-yuinyee.chew@starfivetech.com>

Update Gigadevice norflash list:
gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256

Add Silicon Kaiser norflash list:
sk25lp128

Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Li Yong <yong.li@intel.com>
Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Signed-off-by: John Chew <yuinyee.chew@starfivetech.com>
---
 EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
index e16c1c6a14..422fdac851 100644
--- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
+++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
@@ -1,6 +1,7 @@
 /** @file
 *
 *  Copyright (c) 2017 Marvell International Ltd.
+*  Copyright (c) 2023 StarFive, Technology Co., Ltd. All rights reserved.<BR>
 *
 *  SPDX-License-Identifier: BSD-2-Clause-Patent
 *
@@ -33,12 +34,20 @@ STATIC CONST NOR_FLASH_INFO  NorFlashIds[] = {
   { L"en25q128b",      { 0x1c, 0x30, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
   { L"en25s64",        { 0x1c, 0x38, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
   /* GIGADEVICE */
-  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
+  { L"gd25q16",        { 0xc8, 0x40, 0x15 }, 3, 256, 64 * 1024,  32,   NOR_FLASH_ERASE_4K                       },
+  { L"gd25q32",        { 0xc8, 0x40, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
   { L"gd25lq32",       { 0xc8, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   NOR_FLASH_ERASE_4K                       },
+  { L"gd25q64b",       { 0xc8, 0x40, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
+  { L"gd25lq64c",      { 0xc8, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  NOR_FLASH_ERASE_4K                       },
+  { L"gd25q128",       { 0xc8, 0x40, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
+  { L"gd25lq128",      { 0xc8, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
+  { L"gd25q256",       { 0xc8, 0x40, 0x19 }, 3, 256, 64 * 1024,  512,  NOR_FLASH_ERASE_4K                       },
   /* ISSI */
   { L"is25lp032",      { 0x9d, 0x60, 0x16 }, 3, 256, 64 * 1024,  64,   0                                        },
   { L"is25lp064",      { 0x9d, 0x60, 0x17 }, 3, 256, 64 * 1024,  128,  0                                        },
   { L"is25lp128",      { 0x9d, 0x60, 0x18 }, 3, 256, 64 * 1024,  256,  0                                        },
+  /* XINKAI / SILICON KAISER */
+  { L"sk25lp128",      { 0x27, 0x70, 0x18 }, 3, 256, 64 * 1024,  256,  NOR_FLASH_ERASE_4K                       },
   /* MACRONIX */
   { L"mx25l2006e",     { 0xc2, 0x20, 0x12 }, 3, 256, 64 * 1024,  4,    0                                        },
   { L"mx25l4005",      { 0xc2, 0x20, 0x13 }, 3, 256, 64 * 1024,  8,    0                                        },
-- 
2.34.1

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[John Chew]

Hi Heinrich, Laszlo,

Thank you very much for your support! Really appreciate it =D

My account just approved few days ago, so original patch (submit few weeks back) is not in the mailing list.

Regards,
John

-----Original Message-----
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> 
Sent: Friday, October 20, 2023 6:44 PM
To: Laszlo Ersek <lersek@redhat.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io; YuinYee Chew <yuinyee.chew@starfivetech.com>; ardb@kernel.org
Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 20.10.23 11:49, Laszlo Ersek wrote:
> On 10/18/23 10:57, Ard Biesheuvel wrote:
>> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew 
>> <yuinyee.chew@starfivetech.com>  wrote:
>>> Dear Maintainers,
>>>
>>> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>>>
>> Thanks for the reminder. I don't have time to review this myself but 
>> I'm happy to merge it if someone else reviews it
> Heinrich gave an Acked-by up-thread.
> 
> (I'd just go ahead and merge this myself to help you out a bit, but I 
> don't have access to the original patch!)
> 
> Laszlo

See appendix.

Best regards

Heinrich


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109834): https://edk2.groups.io/g/devel/message/109834
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Laszlo Ersek]

On 10/20/23 13:30, John Chew wrote:
> Hi Heinrich, Laszlo,
> 
> Thank you very much for your support! Really appreciate it =D
> 
> My account just approved few days ago, so original patch (submit few weeks back) is not in the mailing list.

Let me rectify that in a minute.

Laszlo

> 
> Regards,
> John
> 
> -----Original Message-----
> From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> 
> Sent: Friday, October 20, 2023 6:44 PM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Li Yong <yong.li@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Abner Chang <abner.chang@amd.com>; Daniel Schaefer <git@danielschaefer.me>; devel@edk2.groups.io; YuinYee Chew <yuinyee.chew@starfivetech.com>; ardb@kernel.org
> Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
> 
> On 20.10.23 11:49, Laszlo Ersek wrote:
>> On 10/18/23 10:57, Ard Biesheuvel wrote:
>>> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew 
>>> <yuinyee.chew@starfivetech.com>  wrote:
>>>> Dear Maintainers,
>>>>
>>>> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>>>>
>>> Thanks for the reminder. I don't have time to review this myself but 
>>> I'm happy to merge it if someone else reviews it
>> Heinrich gave an Acked-by up-thread.
>>
>> (I'd just go ahead and merge this myself to help you out a bit, but I 
>> don't have access to the original patch!)
>>
>> Laszlo
> 
> See appendix.
> 
> Best regards
> 
> Heinrich
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109844): https://edk2.groups.io/g/devel/message/109844
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Ard Biesheuvel]

On Fri, 20 Oct 2023 at 11:49, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 10/18/23 10:57, Ard Biesheuvel wrote:
> > On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
> > <yuinyee.chew@starfivetech.com> wrote:
> >>
> >> Dear Maintainers,
> >>
> >> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
> >>
> >
> > Thanks for the reminder. I don't have time to review this myself but
> > I'm happy to merge it if someone else reviews it
>
> Heinrich gave an Acked-by up-thread.
>
> (I'd just go ahead and merge this myself to help you out a bit, but I
> don't have access to the original patch!)
>

OK, thanks.

I'll queue this up.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109845): https://edk2.groups.io/g/devel/message/109845
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Laszlo Ersek]

On 10/20/23 14:25, Laszlo Ersek wrote:
> On 10/20/23 13:30, John Chew wrote:
>> Hi Heinrich, Laszlo,
>>
>> Thank you very much for your support! Really appreciate it =D
>>
>> My account just approved few days ago, so original patch (submit few weeks back) is not in the mailing list.
> 
> Let me rectify that in a minute.

huh, I thought I'd find the patch email as "pending moderation" in the
moderators' queue, but it's not there.

(I can see you having been added as a member; your new messages seem to
be reflected, so that should be fine.)

I assume either one of the mods mis-clicked on your initial submission
(from 29 September, I think?), rejecting or deleting it instead or
approving it, or else nobody had taken notice and your patch email
"timed out". (I don't know if that's possible with groups.io; just
guessing.)

Either way I think I should have it from Heinrich now...

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109849): https://edk2.groups.io/g/devel/message/109849
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[Laszlo Ersek]

On 10/20/23 14:25, Ard Biesheuvel wrote:
> On Fri, 20 Oct 2023 at 11:49, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> On 10/18/23 10:57, Ard Biesheuvel wrote:
>>> On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
>>> <yuinyee.chew@starfivetech.com> wrote:
>>>>
>>>> Dear Maintainers,
>>>>
>>>> Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help.
>>>>
>>>
>>> Thanks for the reminder. I don't have time to review this myself but
>>> I'm happy to merge it if someone else reviews it
>>
>> Heinrich gave an Acked-by up-thread.
>>
>> (I'd just go ahead and merge this myself to help you out a bit, but I
>> don't have access to the original patch!)
>>
> 
> OK, thanks.
> 
> I'll queue this up.

Thanks, Ard --> <https://github.com/tianocore/edk2/pull/4933>, commit
c591395f4ab5.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109867): https://edk2.groups.io/g/devel/message/109867
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

[John Chew]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Thanks for the effort, everyone!! =D


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109885): https://edk2.groups.io/g/devel/message/109885
Mute This Topic: https://groups.io/mt/101660590/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 816 bytes --]