From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9CDB87803D0 for ; Fri, 29 Sep 2023 16:00:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=a8GhZ2nnKlX1KKwXIfvQEUw42Oh5U5dwZHfEqZ5UARw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696003255; v=1; b=ty401pYmZaI4DuehfFv1HeQRDX+iZqv9W9VS76PEjghlFgW7xhlleKLoM6R0tED/8WCCSnBk 3TBR5mYOFgwcoltmBStJws1bt1sCLdJNWfxeLtvEX48JD6p7+b2DQteUeEBp4IjCKNAkKYZOk+I CggRQIV3jifELaTVfCIV5j5o= X-Received: by 127.0.0.2 with SMTP id bEOZYY7687511xM0faGCE1CX; Fri, 29 Sep 2023 09:00:55 -0700 X-Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mx.groups.io with SMTP id smtpd.web10.18369.1695996636737284571 for ; Fri, 29 Sep 2023 07:10:37 -0700 X-Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DEA643F685 for ; Fri, 29 Sep 2023 14:10:32 +0000 (UTC) X-Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fe182913c5so126808555e9.0 for ; Fri, 29 Sep 2023 07:10:32 -0700 (PDT) X-Gm-Message-State: LHJHENZeRembdrNKwwX5f55Qx7686176AA= X-Received: by 2002:a05:600c:2207:b0:3f6:58ad:ed85 with SMTP id z7-20020a05600c220700b003f658aded85mr3979140wml.10.1695996632434; Fri, 29 Sep 2023 07:10:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJ0DdUUnQzpWABhDnY2h6nO6FJzQdDbICW4ykzq6VP5GS+bgmBx2TzB97GU2tu/byaPGy7ww== X-Received: by 2002:a05:600c:2207:b0:3f6:58ad:ed85 with SMTP id z7-20020a05600c220700b003f658aded85mr3979087wml.10.1695996631374; Fri, 29 Sep 2023 07:10:31 -0700 (PDT) X-Received: from [192.168.123.67] (ip-178-202-040-247.um47.pools.vodafone-ip.de. [178.202.40.247]) by smtp.gmail.com with ESMTPSA id c19-20020a7bc853000000b0040646a708dasm1501631wml.15.2023.09.29.07.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Sep 2023 07:10:30 -0700 (PDT) Message-ID: <183a71a0-5df1-4caf-ba7c-49a704d55bc2@canonical.com> Date: Fri, 29 Sep 2023 16:10:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list To: YuinYee Chew Cc: Sunil V L , Li Yong , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , "devel@edk2.groups.io" References: <20230929020222.2010-1-yuinyee.chew@starfivetech.com> <4487065a-ac8f-4a73-a3e5-b7069df9e7d3@canonical.com> <7844b7331b5f42019dfdf3fc706671c0@EXMBX073.cuchost.com> From: Heinrich Schuchardt In-Reply-To: <7844b7331b5f42019dfdf3fc706671c0@EXMBX073.cuchost.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ty401pYm; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 29.09.23 15:35, YuinYee Chew wrote: > Hi Heinrich, >=20 > Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}" > gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-= nor-flash/gd25lq128d.html > gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi-= nor-flash/gd25lq128e > So, I'm thinking to put it as "gd25lq128" to represent both "d" and "e". > If sync with Linux, gd25lq128d will be better. >=20 > Do you have any suggestion on this? > Or anyone have any opinion? >=20 > Thanks again for the feedback! =3D) Thank you for the explanation. My understanding is that these strings are for display only. So we=20 should be fine with the patch as is. Best regards Heinrich -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109211): https://edk2.groups.io/g/devel/message/109211 Mute This Topic: https://groups.io/mt/101660590/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-