From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by mx.groups.io with SMTP id smtpd.web12.3007.1651525536680984764 for ; Mon, 02 May 2022 14:05:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=pOOGoRSv; spf=permerror, err=parse error for token &{10 18 stspg-customer.com}: limit exceeded (domain: oracle.com, ip: 205.220.165.32, mailfrom: annie.li@oracle.com) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 242IU6jX030616; Mon, 2 May 2022 21:05:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=ozBg/BqyjWVLNUjhf3K+ywQYP7vUyVA+XqFntTMCn3E=; b=pOOGoRSviaRLbdjFw+al14F2gAH2TvkGXo4tCsZE5e+6TeltxrGe7rFCiXCfGT8MpoWt JEQYRHFn9dNBdoVMmUAH7W+8crLXQBXF4c7QbYadu8p0BXwB80LyXv5AXFwhhEwr2QIx 7LBvxm/Ax9jYZQgik4pfmPIsiD8F30Dh9U2jiCCS+pAXVYpdtSMXNIgOphAmft7UtTD8 jNDfDOfHzR9Lg597yoseUgVHgLoYENUAIQifVwa4YUEy5r/jj9pAg0wTmxQXyhxvLMX1 ml9wvBU9sSN0g7sw+p0mIF0h9zl+ZwyoW7B8XaGWlRzLepgnL4Acfuv44YII7TA5wACs 3Q== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fruq0ccyq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 May 2022 21:05:34 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 242KtirC020216; Mon, 2 May 2022 21:05:32 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2047.outbound.protection.outlook.com [104.47.51.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fruj7yu90-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 May 2022 21:05:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZaUu1b3LIOcbn54PU0jYQz9fYJ4w1LG+L93f7GynMlQIEK3TYv1HYclfsQJYrKCvO34K1Dm1fEr+6Hx3WIqaH/y6ZvhJv1fbZQeQ+y4oAiRKKQjbqHMqOXXHblpJQL5W4w3kHdX0/eDQeJqr2QRaXcLcR0pMOM8nBtkT45K1f4ib9pCN0XQSSumi3dZUu6yy8Jf5e3WodzvtpHDi3yadgko3q0lJWuMImExqdk2SBbX7rDSmNfDuYcB3+J1HBZZbbXNfrkQCuLrtaED8Wov8XrNW6d78W2nAmYAO08j4pR1RmX5+e9gPMxb9qIHsf5x9BZ6KUmGX+WKubakQcwREYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozBg/BqyjWVLNUjhf3K+ywQYP7vUyVA+XqFntTMCn3E=; b=QFdFQ7sOAQUJzvkXN7VUwkAD2Q1jWhVNU0V+XIBLHuZluNLTDMLwz6hEyOy6LiQUBJH2xW1gQX3LZjmjSR2dYU3yaeJiswxuu6IEstkhOXnRZFHSI8N0LqaWMO+Wo+k7oP9ZHdrpwq30ak50nqxEtQeljKILO6F5SqiH7mVKfWqMu2L93JXoc1ktq8rptpkUV5Dt9KC9ZJ/bUNUqu/vGGa8Bs8cO1vQ959oW5UecuQKzbW1AOnpDqAGo+/6WnsSwTb9M1jxxyB9Q4LHpLoIkZaGF3eb8yecXE1F1V4ubhlOIyD8NFFvcbgBqVVNRTzYg+eQdOXLFSAoDKGCfmuboPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ozBg/BqyjWVLNUjhf3K+ywQYP7vUyVA+XqFntTMCn3E=; b=h//frAz1M7mMxYxg02U0w5P+qf06AWz6j3i0+0w6rgJwYhrOsNZ1ipz4ieFtWIRClyZOFvzSJm4BX9BtHixsZkQ9b4ZaQCXe4S73VsGfJYJ07BCSqaY3XpB8B8BTOguzWR+uMUDYUEBhv0sbYji8uGndUeUSKlLn1jk94JbxeOI= Received: from DM6PR10MB2523.namprd10.prod.outlook.com (2603:10b6:5:b2::27) by CH0PR10MB4921.namprd10.prod.outlook.com (2603:10b6:610:c2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Mon, 2 May 2022 21:05:31 +0000 Received: from DM6PR10MB2523.namprd10.prod.outlook.com ([fe80::458a:c710:f53f:9fb1]) by DM6PR10MB2523.namprd10.prod.outlook.com ([fe80::458a:c710:f53f:9fb1%5]) with mapi id 15.20.5186.028; Mon, 2 May 2022 21:05:31 +0000 Message-ID: <184a69b4-5049-e55b-d50c-3253d7a14544@oracle.com> Date: Mon, 2 May 2022 17:05:26 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/OvmfPkg*.dsc: Increase ACPI Reclaim memory size To: devel@edk2.groups.io Cc: lersek@redhat.com, karl.heubaum@oracle.com, aaron.young@oracle.com References: <16E62E6A940424A8.9469@groups.io> From: "annie li" In-Reply-To: <16E62E6A940424A8.9469@groups.io> X-ClientProxiedBy: SA0PR11CA0068.namprd11.prod.outlook.com (2603:10b6:806:d2::13) To DM6PR10MB2523.namprd10.prod.outlook.com (2603:10b6:5:b2::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dae2a26e-13f7-4694-d0b9-08da2c7f7d7b X-MS-TrafficTypeDiagnostic: CH0PR10MB4921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mreOddM4JcXB6jlWhazvstIIg/s7cU54PO3QkOZp69A3KEmaa5cr1sJeHuvsTfsqZqJe9w45V9jHhuE7JvpMznTKb7OndyzL4YnphxSSi2/JUaEzGbnzru2yLsSbcyErtuaInvi1Jqg00o07Ef3UyfHbw9u/Y3eON+x+CXnsWuC2SesQ0AaTRM5Ucl7CZnubr8X7FoRVsebrIXESlL7IPoqX7TuXf28yznxgVwc0OdGHTMdgVqLxh27mGOLk2MlADPoTB3zJ6lMjvHDhixIlDLmVqcC8VasLASNYOWfjt7YZamDSKH4GGq/IF0q59pxueOoEYNaNheLNTGc8TP7/GK73R14qBeh90nEYJFoIM8uS8fKg4Ef6YZA5mSto2wccBEaKTUnmoZi4JQ0/2qaAo/jfNmoZZgNdrCjNd7HE8S96hwxC1x9r1Om76wSfp7REUNj+LJ6QF2crtxqvCHpRP15fFF2H65HxkUt0+m8/WtKWxnRb3Z7nvXlrsHIpmgHYqBWJQrFS+t+8/LEx5BLbEeT4PNFxABykjxl03jZQY5YJXyAXT6odoHYoUIsDQV3TSimW9DXRka2ojRwma//BPu9yQRNYEC3VSGiQZc2T3FMCyXxgEW67PL8ehritr8K5m57obOUn7gpPaa4KcAeDt5bCFZn3WQRLojq9H44LjOU12Ot5MH2jCDPGloSEAM46aJtuCszUO2WZZRwlkpVTlKzVFo1V4j6sUzjd4X0x1xQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB2523.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(5660300002)(6486002)(6512007)(83380400001)(316002)(19627235002)(4326008)(8676002)(66946007)(8936002)(31696002)(86362001)(66556008)(38100700002)(2616005)(66476007)(107886003)(26005)(186003)(36756003)(2906002)(508600001)(31686004)(6506007)(53546011)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmkwYnJwTmNuVHAyZE9WZEd0RzFiaFZ4R1o4ZEVmak1ydytrNXFyb01UL084?= =?utf-8?B?YUVoZjlrSkJLc1FLWU1hNzVmSUJqL1Q1UUVacFY4Wmd0VVljRWgrMld5d3dq?= =?utf-8?B?ejJLN2dRWWtrQnNpYjNjT3l5L09lYWpOOFdhYnVvdjNGN3JzZzFsK1BsaW1z?= =?utf-8?B?bGtacnlqWWNCVFNYR2ozcGVUNXVuczBMOFJMOHdYZmxreGduZTI2NlFUdWkz?= =?utf-8?B?TGZQeEtTUE53WXhCK013MkdaRGZ2am5MaG8xNWdyZ1NSNTJteThtWklYWisz?= =?utf-8?B?Tk81dWxYbUdYeHNVTzhtKzF5Wk5mYXRmUkREaVRxQmQ1c1kvczNjck0xSE1U?= =?utf-8?B?dE10QkE1bVFSS05SWnVKcStvcnJtNmJ1TXlTWjFWZXcwblgzeFpQRzBFM1p1?= =?utf-8?B?OXUvR1F2R0xPaDgvcjRRS2VDWm1tSVRRbXJXUGd5TWhjYi9nclJTd3FTaGdt?= =?utf-8?B?WFR5Q3pPK2JjZkc0UXBaNlc4U1BLd0toaHpSTWlOV0VDa1FVa3ZJdXJBL2t5?= =?utf-8?B?K0JiR1ZZTWZzY3ZIYkppM2ZNeUkwTjk4NjhpL0hvdEF4Ky9meVZxUWNyUGVJ?= =?utf-8?B?Q090SGtMdjV1ei9WRzEwYmZiN0ZtTUx0WHpYdjZMTXo1ekp0aXFNVk5RbUdh?= =?utf-8?B?cW1rNkgxYnhRUVBXQ29yRkQ5SHA3Um41NWFETExBY29MOURPTmhHNitORUN3?= =?utf-8?B?c2lTaHZRWGpBYUNNSFJvN2drSkwxOFVZcVlhVjRVU1Zzb2IvT29HT20zNzRp?= =?utf-8?B?bFg0Q3FjWG9sQVo5dGJjNS81OW1pcUd4NkpEZ09vTlRKOXY2Z1E2U3Fia0tn?= =?utf-8?B?SXBsb3UyQkM2NkhHdytLWUtmSE5ZU0FCNUNOakFoNHJwS3oyRFYxTGFJNzh2?= =?utf-8?B?SnBPR0lHQlk5UUQ5WXNlSmxZSjdTaUlxa0QwY0lkOGV6NStoQUd0TkJKY21h?= =?utf-8?B?NkFUdS9DVkZ3TDgrL0pRZEFMVjd5ZHliV21OTjJOVENBY3d3Vm1QYU0yNy9p?= =?utf-8?B?TDJwSlRjYm00M3R4WXZRcThtdlhUZHlVL2dtaUFkMkdJSVo5Wk8xcTJnaENm?= =?utf-8?B?dDVseTBaeitlc3JEaU53aDl5WjJvcEE5eWtzbkNhdTdHNExkYWxTaEtaS2t5?= =?utf-8?B?YUZwUDZrQTVncnRjZG11UkVxNUJYNy9NVFN5REkxM3hmRk01My84eFFlUGRm?= =?utf-8?B?TzJHSVV4VUY5ZDFvZjNGVHpQZ040ckp4Tmd0Rm1vbm9VUGIyNE1CSmJUWTZx?= =?utf-8?B?cThvYitoOGJBU21HSE9VQ21uNEtkRnFjQTgrSFdhcXpkNDVhN0tDUTFKUHlu?= =?utf-8?B?cUFSNFkybWdhSUVRUDRMY05JK0RUTVRtTWk4REhwY24wZ296VFFmVE1OaEg2?= =?utf-8?B?bkRBeDhYVzEwWjhYVU5CRzgybUw0WVJBMEhrWDg2QWttRVQxR0RDVFF3NWwz?= =?utf-8?B?aUdEam5iQjQ1b3NheGtqcTZFZGI3Y0g2NWV4VjhJTUxyMlpyU0p3cWVRbVJ2?= =?utf-8?B?S1kwSERCdnowSkd2MkdJdVFxVmwwemRpcXhnck5vU3d1WmVJU1ZEMFJoazk5?= =?utf-8?B?YVpFcHFoVHM4WmRMRGR2NzZkL1FxU2JwazI1V3pjbU1YanlxcHIzdGZKTWhx?= =?utf-8?B?K01mbmlmV1FGZ3FhVjNJMFlrWlorSVowMkE0anZpTXNma3djcDZGZzlWQ2JD?= =?utf-8?B?T3N5akh6amxVTVNUY1ZXbEhzaTZXdndkY1pUUExaejFGSlpIUlBWMHFFVlJx?= =?utf-8?B?SldOd2pNdFh1UHAyNWpCdDZVdnZhbWNLbERILzR4Z2VoT2REajBUU1FTWGpt?= =?utf-8?B?dXBZYzFyWHk2NnptZnllei9BQm5YS0FRREdBSkpYcUJ6Z2lJdE1GVUdsOUJ2?= =?utf-8?B?T2F4STczSThZWktUOFh4eFRwT0d1cGpCRW5HQVFGNmZvTmhweTE5cFc4Y05Z?= =?utf-8?B?MkFJdVUySlNOOHNVSnI3QW94UHJORURxNGhySG1IUDlJenAvR2J6L3ZNdkpI?= =?utf-8?B?TVdxOUJJSXBOLy9kSVM4dlBDT0JjaHJpMzZjUGU1SFBHUGkva1lCV25aTGU5?= =?utf-8?B?Ri9wbDlZM1VRdjBmei9kU05TemV1czVUV0owTnRNYmF6SERtV2xmTFB0K09l?= =?utf-8?B?SDcvZWNWcWVicEMxMktCSDNFTEJQNDNDaVd4Vy9rWXlNeGE5K3hqSHJOSlYy?= =?utf-8?B?aEhwcDZOZEl6UWZOdHZTN1R4VU9rR1hBQnVZbzlzL0N2T0l2YzJYS2ZCWE1a?= =?utf-8?B?eVhZeHpmMllrNmZoV0xNUndqODJiZXJjb0h6NlY4YUdPeXl2ZVZrQkRkYTFW?= =?utf-8?B?cHBFRVJ6R1lwY1p5RHZLTGsyYWNzc0ZNR2xVYlBpVklyaVRmbW5GUT09?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dae2a26e-13f7-4694-d0b9-08da2c7f7d7b X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB2523.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 21:05:31.4237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /7J20jeyhwy0B5U1cPS9uQEmwo1yexToArvuaeY80JXYZSx/KX9rMVqh1rkNG4ASlorwdgO9JcKTOQUkGAeVAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4921 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-02_06:2022-05-02,2022-05-02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205020154 X-Proofpoint-ORIG-GUID: vsffTHzNy6jU9yb4okXzw0B5OmjOt4dl X-Proofpoint-GUID: vsffTHzNy6jU9yb4okXzw0B5OmjOt4dl Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello I am wondering if anyone will review this patch please? Any comments are welcome. Thanks Annie On 4/15/2022 5:15 PM, annie li wrote: > The current ACPI Reclaim memory size is set as 0x10(64k). The > ACPI table size will be increased if the memory slots' number of > the guest gets increased. In the guest with more memory slots, > the ACPI Reclaim memory size may not be sufficient for hibernation. > This may cause resume failure of the hibernated guest that was > booted up with a fresh copied writable OVMF_VARS file. However, > the failure doesn't happen in following hibernation/resume > cycles. > > The ACPI_MAX_RAM_SLOTS is set as 256 in the current QEMU. With > ACPI_MAX_RAM_SLOTS, 18 pages are required to be allocated in ACPI > Reclaim memory. However, due to the 0x10(16 pages) setting, 2 extra > pages will be allocated in other space. This may break the > hibernation/resume in the above scenario. > > This patch increases the ACPI Reclaim memory size to 0x12, i.e. > PcdMemoryTypeEfiACPIReclaimMemory is set as 0x12(18 pages). > > Signed-off-by: Annie Li > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 29eea82571..fb158f98c9 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -547,7 +547,7 @@ > # unknown) workloads / boot paths. > > # > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > > - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > > + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 56d3c49ab2..30d47ca28a 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -552,7 +552,7 @@ > # unknown) workloads / boot paths. > > # > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > > - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > > + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index f0924c0f9d..6c10ceedd7 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -552,7 +552,7 @@ > # unknown) workloads / boot paths. > > # > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > > - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > > + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 >