Re: [PATCH 4/5] OvmfPkg: remove EnterS3WithImmediateWake () from ResetSystemLib

["Laszlo Ersek" <lersek@redhat.com>]

On 01/06/20 16:13, Ard Biesheuvel wrote:
> EnterS3WithImmediateWake () no longer has any callers, so remove it
> from ResetSystemLib.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index 98dd80e33c05..2f2e1293a3ef 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -101,24 +101,6 @@ ResetShutdown (
>  }
>  
>  
> -/**
> -  Calling this function causes the system to enter a power state for capsule
> -  update.
> -
> -  Reset update should not return, if it returns, it means the system does
> -  not support capsule update.
> -
> -**/
> -VOID
> -EFIAPI
> -EnterS3WithImmediateWake (
> -  VOID
> -  )
> -{
> -  AcpiPmControl (1);
> -  ASSERT (FALSE);
> -}
> -
>  /**
>    This function causes a systemwide reset. The exact type of the reset is
>    defined by the EFI_GUID that follows the Null-terminated Unicode string passed
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>