From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.5904.1578328161764074572 for ; Mon, 06 Jan 2020 08:29:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P4wYnxfL; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578328160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MoelFOpcepEDu9T7i2vMdyibSFAIQ9yPTVu8D6lryDc=; b=P4wYnxfLcZnfflAlcaxGqnri8LwWjFZ+C/eFZX4aq7C6oplPG3cl0cc05ILAcJNO6JkjqT LcuGa/HXzGYIbamrzvkpGNz1Rp9HkvSfsLWIOxYrk4BO0U5N+/jaxVb54fgGt2bvRtfe3L vzNuDD94P1NMFJFMfdarbx4OBCkGmsI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-pqFxYGf0MXOLmk2179HcpQ-1; Mon, 06 Jan 2020 11:29:17 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 301A1802C9B; Mon, 6 Jan 2020 16:29:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-24.ams2.redhat.com [10.36.117.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B2286A846; Mon, 6 Jan 2020 16:29:11 +0000 (UTC) Subject: Re: [PATCH 4/5] OvmfPkg: remove EnterS3WithImmediateWake () from ResetSystemLib To: Ard Biesheuvel , devel@edk2.groups.io Cc: maurice.ma@intel.com, guo.dong@intel.com, benjamin.you@intel.com, ray.ni@intel.com, liming.gao@intel.com, hao.a.wu@intel.com References: <20200106151310.12322-1-ard.biesheuvel@linaro.org> <20200106151310.12322-5-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: <184c18a3-570c-e8ef-6baa-60f090c5a321@redhat.com> Date: Mon, 6 Jan 2020 17:29:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200106151310.12322-5-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: pqFxYGf0MXOLmk2179HcpQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 01/06/20 16:13, Ard Biesheuvel wrote: > EnterS3WithImmediateWake () no longer has any callers, so remove it > from ResetSystemLib. > > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > index 98dd80e33c05..2f2e1293a3ef 100644 > --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > @@ -101,24 +101,6 @@ ResetShutdown ( > } > > > -/** > - Calling this function causes the system to enter a power state for capsule > - update. > - > - Reset update should not return, if it returns, it means the system does > - not support capsule update. > - > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ) > -{ > - AcpiPmControl (1); > - ASSERT (FALSE); > -} > - > /** > This function causes a systemwide reset. The exact type of the reset is > defined by the EFI_GUID that follows the Null-terminated Unicode string passed > Reviewed-by: Laszlo Ersek