Re: [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

[Laszlo Ersek <lersek@redhat.com>]

On 12/12/17 16:01, Gao, Liming wrote:
> Laszlo:
>   Thanks!
> 
> Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks! Pushed it as e3e40c83fd2c.

Zenith432, thanks for the contribution -- for your next patch; please
send the updated versions as separate top-level postings, such as [PATCH
v2], [PATCH v3] etc. It seems that your original posting in this thread
was sent just fine with git-send-email, but the updated variants were
just pasted into emails using Thunderbird. So, in order to apply the
final version, I had to reconstruct the commit manually from the email.
That's a bit error prone (and slow).

"git format-patch" takes an option of the form "-v2", "-v3" etc; it will
fill in the subject prefix accordingly.

If you want to add extra comments on the patch just about the v1->v2,
v2->v3 differences, there are two possibilities:

- Simply add those remarks to the commit message. (Some edk2 developers
do this all the time, and it is fine IMO, although not the universally
recommended practice.)

- Use "git notes edit" to edit notes on commits -- they don't become
part of the commit message, and don't change the SHA1 commit hashes.
Then, use "git format-patch -v2 --notes" to format the updated version,
for mailing out. This will include the notes in a separate email
"section" such that humans will read it, but "git-am" / "git-push" will
not carry it over.

You can find more tips if you are interested, in:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks!
Laszlo