From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D71221A1099A for ; Tue, 12 Dec 2017 09:37:46 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FB0C6A7DF; Tue, 12 Dec 2017 17:42:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-105.rdu2.redhat.com [10.10.120.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 224DC60C9E; Tue, 12 Dec 2017 17:42:23 +0000 (UTC) To: "Gao, Liming" , Zenith432 Cc: "edk2-devel@lists.01.org" , "Kinney, Michael D" References: <1667068483.2112668.1512898346914.ref@mail.yahoo.com> <1667068483.2112668.1512898346914@mail.yahoo.com> <90e6e057-3fa3-eed9-46a2-44bb8a78e652@users.sourceforge.net> <147f3c39-cfc4-a0ad-44c8-a58487624c7f@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E191187@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <185505b7-a1e3-71f2-81c2-d06663031e7e@redhat.com> Date: Tue, 12 Dec 2017 18:42:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E191187@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 12 Dec 2017 17:42:25 +0000 (UTC) Subject: Re: [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 17:37:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/12/17 16:01, Gao, Liming wrote: > Laszlo: > Thanks! > > Reviewed-by: Liming Gao Thanks! Pushed it as e3e40c83fd2c. Zenith432, thanks for the contribution -- for your next patch; please send the updated versions as separate top-level postings, such as [PATCH v2], [PATCH v3] etc. It seems that your original posting in this thread was sent just fine with git-send-email, but the updated variants were just pasted into emails using Thunderbird. So, in order to apply the final version, I had to reconstruct the commit manually from the email. That's a bit error prone (and slow). "git format-patch" takes an option of the form "-v2", "-v3" etc; it will fill in the subject prefix accordingly. If you want to add extra comments on the patch just about the v1->v2, v2->v3 differences, there are two possibilities: - Simply add those remarks to the commit message. (Some edk2 developers do this all the time, and it is fine IMO, although not the universally recommended practice.) - Use "git notes edit" to edit notes on commits -- they don't become part of the commit message, and don't change the SHA1 commit hashes. Then, use "git format-patch -v2 --notes" to format the updated version, for mailing out. This will include the notes in a separate email "section" such that humans will read it, but "git-am" / "git-push" will not carry it over. You can find more tips if you are interested, in: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Thanks! Laszlo