Re: [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

[Laszlo Ersek <lersek@redhat.com>]

On 10/02/18 14:17, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> This is for conformance with the TCG "Platform Reset Attack Mitigation
> Specification". Because clearing the CPU caches at boot doesn't impact
> performance significantly, do it unconditionally, for simplicity's
> sake.
> 
> Flush the cache on all logical processors, thanks to
> EFI_PEI_MP_SERVICES_PPI and CacheMaintenanceLib.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Message-Id: <20181002120730.13013-1-marcandre.lureau@redhat.com>
> ---
> 
> v3:
>   - update top comment with notes about TCG spec
>   - sort headers inclusion

So, meta comments first...

I got this patch (v3) in three variants:


(a) the one you sent me off-list, as quoted-printable:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable


(b) this message, reaching me directly from you:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


(c) this message, reflected by the edk2-devel list software, from you to me:

Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64


Results:
- git-am fails with (a).
- git-am *also* fails with (c).
- git-am only works on (b).

Which means that your setup is now correct, but some mail server on path
(c) is broken, and corrupts your patch email when it transcodes the
email to base64. Yay!

I guess I'll work with copy (b), in my inbox.

Sigh, is the mailing list workflow actually *more* broken than github
pull requests? I thought that was impossible, but I guess I'm being
proven wrong.

Laszlo