From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E9A52211616A2 for ; Tue, 2 Oct 2018 05:39:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CC50DB947; Tue, 2 Oct 2018 12:39:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-142.rdu2.redhat.com [10.10.120.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45AF860C13; Tue, 2 Oct 2018 12:38:57 +0000 (UTC) To: marcandre.lureau@redhat.com, edk2-devel@lists.01.org Cc: Jordan Justen , Anthony Perard References: <20181002121725.17178-1-marcandre.lureau@redhat.com> From: Laszlo Ersek Message-ID: <18640730-a6cc-611e-ad8a-a5a5ca5bb75a@redhat.com> Date: Tue, 2 Oct 2018 14:38:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181002121725.17178-1-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 02 Oct 2018 12:39:01 +0000 (UTC) Subject: Re: [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 12:39:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 10/02/18 14:17, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally, for simplicity's > sake. > > Flush the cache on all logical processors, thanks to > EFI_PEI_MP_SERVICES_PPI and CacheMaintenanceLib. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marc-André Lureau > Message-Id: <20181002120730.13013-1-marcandre.lureau@redhat.com> > --- > > v3: > - update top comment with notes about TCG spec > - sort headers inclusion So, meta comments first... I got this patch (v3) in three variants: (a) the one you sent me off-list, as quoted-printable: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable (b) this message, reaching me directly from you: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit (c) this message, reflected by the edk2-devel list software, from you to me: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Results: - git-am fails with (a). - git-am *also* fails with (c). - git-am only works on (b). Which means that your setup is now correct, but some mail server on path (c) is broken, and corrupts your patch email when it transcodes the email to base64. Yay! I guess I'll work with copy (b), in my inbox. Sigh, is the mailing list workflow actually *more* broken than github pull requests? I thought that was impossible, but I guess I'm being proven wrong. Laszlo