Re: [edk2-devel] [Patch v2 12/12] PrmPkg/Library: HOST_APPLICATION IA32/X64 only

["Michael Kubacki" <mikuback@linux.microsoft.com>]

On 4/5/2023 3:50 AM, Ard Biesheuvel wrote:
> On Tue, 4 Apr 2023 at 20:23, Michael D Kinney
> <michael.d.kinney@intel.com> wrote:
>>
> 
> This patch has no commit log so it is hard to understand the purpose
> of this patch.

I think a message would be helpful as well.
> 
> 
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>> ---
>>   .../UnitTest/DxePrmContextBufferLibUnitTestHost.inf             | 2 +-
>>   .../UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf           | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf b/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf
>> index 7cf6a16867d4..eefaddb10aaf 100644
>> --- a/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf
>> +++ b/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf
>> @@ -17,7 +17,7 @@ [Defines]
>>   #
>>   # The following information is for reference only and not required by the build tools.
>>   #
>> -#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64
> 
> AArch64 also supports PRM so why are you removing it here?
> 
You're correct. The firmware code supports AARCH64. I am not aware of 
these host unit tests being run on a AARCH64 host so I was okay to 
remove this until that was confirmed. Do you have more context Mike?
> 
>> +#  VALID_ARCHITECTURES           = IA32 X64
>>   #
>>
>>   [Sources]
>> diff --git a/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf b/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf
>> index 8aae1f7cd78a..fd4b44a9bf85 100644
>> --- a/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf
>> +++ b/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf
>> @@ -17,7 +17,7 @@ [Defines]
>>   #
>>   # The following information is for reference only and not required by the build tools.
>>   #
>> -#  VALID_ARCHITECTURES           = IA32 X64 ARM AARCH64
>> +#  VALID_ARCHITECTURES           = IA32 X64
>>   #
>>
>>   [Sources]
>> --
>> 2.39.1.windows.1
>>
>>
>>
>> 
>>
>>