From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.128876.1680698770822873445 for ; Wed, 05 Apr 2023 05:46:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=D0u4UMFw; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id D081C20FD075; Wed, 5 Apr 2023 05:46:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D081C20FD075 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1680698770; bh=DufnTQEp+d78KMPXqTWzBovd9R+c0CvUK7RjweciXtE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D0u4UMFwvyw3NJGu1eQfXTY3GbepkP6MaOvkoxg3B9ypWEd5+6dmdbFnguFqW1ux1 +Abg3n+DxjQs58AuEXcEdLWOd+pnHNQho8JL3kULb39kAoB/LVjwPlsEkB4ba3NYgw BH/ythum0aHtbaK7f9e50dGEsbTEzhKF+VQ7iLvA= Message-ID: <1874dbf8-ac18-717e-d1d5-df5a62e111d8@linux.microsoft.com> Date: Wed, 5 Apr 2023 08:46:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [edk2-devel] [Patch v2 12/12] PrmPkg/Library: HOST_APPLICATION IA32/X64 only To: Ard Biesheuvel , devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Nate DeSimone References: <20230404182220.688-1-michael.d.kinney@intel.com> <20230404182220.688-13-michael.d.kinney@intel.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/5/2023 3:50 AM, Ard Biesheuvel wrote: > On Tue, 4 Apr 2023 at 20:23, Michael D Kinney > wrote: >> > > This patch has no commit log so it is hard to understand the purpose > of this patch. I think a message would be helpful as well. > > >> Cc: Michael Kubacki >> Cc: Nate DeSimone >> Signed-off-by: Michael D Kinney >> --- >> .../UnitTest/DxePrmContextBufferLibUnitTestHost.inf | 2 +- >> .../UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf b/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf >> index 7cf6a16867d4..eefaddb10aaf 100644 >> --- a/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf >> +++ b/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf >> @@ -17,7 +17,7 @@ [Defines] >> # >> # The following information is for reference only and not required by the build tools. >> # >> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 > > AArch64 also supports PRM so why are you removing it here? > You're correct. The firmware code supports AARCH64. I am not aware of these host unit tests being run on a AARCH64 host so I was okay to remove this until that was confirmed. Do you have more context Mike? > >> +# VALID_ARCHITECTURES = IA32 X64 >> # >> >> [Sources] >> diff --git a/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf b/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf >> index 8aae1f7cd78a..fd4b44a9bf85 100644 >> --- a/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf >> +++ b/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf >> @@ -17,7 +17,7 @@ [Defines] >> # >> # The following information is for reference only and not required by the build tools. >> # >> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 >> +# VALID_ARCHITECTURES = IA32 X64 >> # >> >> [Sources] >> -- >> 2.39.1.windows.1 >> >> >> >> >> >>