From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.106246.1597911023666934351
 for <devel@edk2.groups.io>;
 Thu, 20 Aug 2020 01:10:23 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 482251FB;
	Thu, 20 Aug 2020 01:10:23 -0700 (PDT)
Received: from [192.168.2.12] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 129943F6CF;
	Thu, 20 Aug 2020 01:10:21 -0700 (PDT)
Subject: Re: [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,
 devel@edk2.groups.io, leif@nuviainc.com
Cc: thomas.abraham@arm.com, Aditya.Angadi@arm.com, richard.storer@arm.com,
 Sami Mujawar <Sami.Mujawar@arm.com>
References: <1597848823-27171-1-git-send-email-vijayenthiran.subramaniam@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <187ea7e2-3d78-ca1c-6e59-d1047c2cd308@arm.com>
Date: Thu, 20 Aug 2020 10:10:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <1597848823-27171-1-git-send-email-vijayenthiran.subramaniam@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

(+ Sami)

On 8/19/20 4:53 PM, Vijayenthiran Subramaniam wrote:
> PcdChipCount constant is used to define the maximum number chips
> included in the multi-chip configuration. Add this constant to the
> RDN1EdgeX2 ACPI tables build information (INF) file to allow this
> constant to be used in the RDN1EdgeX2 ACPI tables.
> 
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
>   Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index 974d9db543..d44f02ab0c 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -45,6 +45,8 @@
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Size
>   
> +  gArmSgiTokenSpaceGuid.PcdChipCount
> +
>     gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerIntrNum
>     gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum
>