public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@nuviainc.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Subject: Re: [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019
Date: Wed, 18 Aug 2021 15:48:34 -0600	[thread overview]
Message-ID: <189fe626-4aa4-ca43-bb6f-87b52e655410@nuviainc.com> (raw)
In-Reply-To: <20210818212859.260-1-michael.d.kinney@intel.com>

For the entire series:


Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>


-- 
Rebecca Cran


On 8/18/21 3:28 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
>
> New in V2
> =========
> * Add LibNetUtil to StdLib/BsdSocketLib in alphebetic order
> * Add comments explaining why SocketDxe is removed from the build.
>    New TianoCore Bugzilla with more details on this issue:
>    https://bugzilla.tianocore.org/show_bug.cgi?id=3572
>
> Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section
> of Python-2.7.10.inf.  Even if sockets are disabled in Python
> config, with the /WHOLEARCHIVE linker option, there are still
> references to the socket related functions.  Add these lib
> classes so the link can pass for both sockets enabled and sockets
> disabled builds.
>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Michael D Kinney (9):
>    StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS
>    StdLib: Add MdeLibs.dsc.inc to StdLib.dsc
>    StdLib: Remove SocketDxe from build
>    StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function.
>    StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF
>    StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS
>    AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc
>    AppPkg/Applications/Python: Enable HAVE_COPYSIGN define
>    AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes
>
>   AppPkg/AppPkg.dsc                                        | 2 ++
>   AppPkg/Applications/Python/Ia32/pyconfig.h               | 2 +-
>   AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h | 2 +-
>   AppPkg/Applications/Python/Python-2.7.10/Python2710.inf  | 7 ++-----
>   AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h  | 2 +-
>   AppPkg/Applications/Python/X64/pyconfig.h                | 3 +--
>   StdLib/BsdSocketLib/BsdSocketLib.inf                     | 4 ++++
>   StdLib/LibC/gdtoa/gdtoa.inf                              | 1 -
>   StdLib/StdLib.dsc                                        | 2 ++
>   StdLib/StdLib.inc                                        | 8 +++++++-
>   10 files changed, 21 insertions(+), 12 deletions(-)
>

      parent reply	other threads:[~2021-08-18 21:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 3/9] StdLib: Remove SocketDxe from build Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes Michael D Kinney
2021-08-18 21:48 ` Rebecca Cran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=189fe626-4aa4-ca43-bb6f-87b52e655410@nuviainc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox