From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EFA0674003A for ; Wed, 31 Jan 2024 04:54:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QEkktX391gzZ0xj8O2v/dPmoqxsGngMG7njchZtGk88=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706676859; v=1; b=ReMXVJ8PBDbu/OrawNuKQEo/EJJnREG8uKtjFTUM7SfezMppcCSGRal3IUCpPBcDL84/ddtF gq8ZEaWRuzm4i3viFjdm4WHIfB/oE22bIa4esxpmv8ipMA7kvO2NWc0C64RnAopc1Zla3ZT57ve 4aaRi7XUmVWVBw2lbzOWadMg= X-Received: by 127.0.0.2 with SMTP id AHuMYY7687511xYlJTluJMqk; Tue, 30 Jan 2024 20:54:19 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.54]) by mx.groups.io with SMTP id smtpd.web11.7758.1706676858461072467 for ; Tue, 30 Jan 2024 20:54:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DsRCjLsV1RPyEUODMWd/KB9d5PXooiTd6+DUrDW6/XT7MHYGS/8pxAWK6VvtPAfv4f3bkEDJG8awwwnZlZzn1WGdnYE3fmYQJMQw2PGJUdfhmjnGT65ejySAs4fP7qjQ3gawjjmWfhpg4LV5ZOwZoXlauS3Y5LeJHYMZc78fp0qpynv3eRgNfdQEyFmNdMUagfmGwskC3prYhRDATBt+moNLjoFPG5bR8hDWUOTKtbXhkUoq3m8/DBjl+9vfl6ofbwWxEhMZcM3L2uL+Kpd16HoLUszCy+EbS7y4qG+5efW/YtHKHiowFe34LvPCSNjHT3khRx//dbMpFqL5VSu9LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UPiNekHO8w82yxy0/Qd8qn4ZTGdubb0Lg/PfXPaQzz0=; b=COmT3hBenAq8QCmQbWVKd2/3YKcxzlsmxvOmR7198pdfyA9tAfNU+KXSvZPXnK45+EwTiT3RSKjXRhIP5BK+Vhob1F60iWU/NP0VfzjHXb+EvhMw5WS2PnFWqLToGt2V7/1Dh1DITty7EecpSy/KoJLrBRqRgjg3pPD17A9xzcj+RU5cQgFKJ04lcMRZRGHSoJWHmObcnXZjYNjzecn/Y9/UlSOBqr0hT0DiI2iT5uUwNwRqOu0RLFWwDUO/UVtJ2jcvF2mPvnI+7GAzhRXEUnXpv7kxUmh6qVP/tHwXohOWv2BN3TJ8wUMjCfgiKJC/XQ8jPe465lLB/QDR7Djleg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by IA0PR12MB8304.namprd12.prod.outlook.com (2603:10b6:208:3dc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Wed, 31 Jan 2024 04:54:14 +0000 X-Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::33f4:38db:736d:b4f2]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::33f4:38db:736d:b4f2%7]) with mapi id 15.20.7228.029; Wed, 31 Jan 2024 04:54:14 +0000 Message-ID: <18a1f0b0-3a14-49c4-b361-5f81028b2da0@amd.com> Date: Wed, 31 Jan 2024 10:24:06 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology To: Tom Lendacky , devel@edk2.groups.io, ray.ni@intel.com CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Kumar, Rahul R" , Gerd Hoffmann References: <17AB54C0527B447C.12800@groups.io> <111fa447-7090-4138-a2e5-ad3a97712ccf@amd.com> <123d075a-9528-4ef6-8505-d54719fcdf5e@amd.com> From: "Abdul Lateef Attar via groups.io" In-Reply-To: <123d075a-9528-4ef6-8505-d54719fcdf5e@amd.com> X-ClientProxiedBy: PN2PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::19) To PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB6466:EE_|IA0PR12MB8304:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e0c013e-6ba9-4d46-53b6-08dc2218ac05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: i+DnqMVHv6f191WUjhIdI872Bw48T5bhR1jHOxcjosWy/pQnHcs2NrtiJ3XNFrfQQXohbBhUFA67obAVpx4hsATkzd5ok9G1Ok1rBmn0H8UPcpVkOQS70cIOgkh7OzKzkeUVR8MNu6PfZmhx3BF/9TpjLdktQP40BOffeW9FmRRX/fFjoXpoFXNL1Y28X9miwaIfeGeZl3rlj9Y3nSsYlb67rMSf65LKuwMZDkftmR5M53GDvbT/pgGWObpAegQrKU2n52pF97O5MWsNOrGweeR/2+1z3MKCeFQ2L0PV00pByGEL2gUtH2GYPHeFwo8/Pht5TCAAb12PJmymOar9+y/ChXiHuoLUcVSgTa3XdJvHVJaGRX0QikgQ2+5835+lcWKX2VU5DP2DvinhZpzOOYJOadW4ejfMgCJZHxO7Vx3bBX9KQrW4R/N8b8iAza93Zj1BUbJSKCtAWxU/HndWLDccXAI8n3F70r5Tcsy1rWp2sjxthEXOERMxnD/VTqTh8du9VOX4GTFKrUwO9k4WDmsQPx/nLDU8maskYE/iiV24yHuJHeclOnOFT9+mKfh4TMeFmzYkcnp+VARNwGznChHnTpxQoSilfH+KRZ7vX/gLoaXZkZ3FkmpPubgULhC3VCwBAgaF8sHZ2lFqm9sVl+3GAWfL5/S/KgG0G9YI82amwa4AoXgTopssq4N7GnxvCsta3Nm0ayxDL94YtPRieI/ZNK5RuaBXr1NZ93Ge6G8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zomt2Qqiz2GScZQW78iz8JR99Nr24Ob11OYZvBr9KSPpm9xnvwNaCzvrgj1o?= =?us-ascii?Q?43mSyxD4Eb/R6wLveEV7BEmVZHVkmd8dN/tQaFaG4OeO1JR0YX8/zv1+FcWd?= =?us-ascii?Q?5Hzf8zKtlFHOmV92jPelDYsang06PZjxAXyumFh1k7VqeUmGtaGPkawk0ftc?= =?us-ascii?Q?NjyAH46OvBl/SzigVDS3NzLofguhtt2m/yMqtWyo1VQSI9brz6prrNQBi1L6?= =?us-ascii?Q?UlVUwyrzYSkvknqITRQNpJ2yDFVywqDW7Fclf/kYYNV0LB7lG+LH8i+x4mXU?= =?us-ascii?Q?/oVNdE6AZLD4qiXGXkiNOssM2Pw9kEXFdxbl5rkO6nfNLU4P4xM0s+tF/Y6c?= =?us-ascii?Q?yLUvjJcoMkimNrENH3g0jY4i+TIPssnI8xGUqsvcE+nyiNrUJm5MjUNan8ZJ?= =?us-ascii?Q?J62CW34PKzZcFvSggeCZxwpKQBzaO2oA3zivwhA/IpKz7IMO0JoqexiT+p5l?= =?us-ascii?Q?g4EZZwT0CK9R9ftEDQBGPh2HzwZrXJR3cNR0mZmK6wpq9tKVLCf/N00AoXMH?= =?us-ascii?Q?cUfZ55ofloBcI7zzhf9njgVFexcPqzxvo/7cLR2Y8lpBOYqhmGe77SUFBcQR?= =?us-ascii?Q?1y4Fo/hYuQj8FkSO9FoPXXjA+Zivlukcc/mUctSwOX1BVOD2ofB+Di3UgXRD?= =?us-ascii?Q?RA4wg2W3/EGK+zl0iFunHEMG/YEMbBc46EGntfwX/qTooiq8FDMpm8XkKBMM?= =?us-ascii?Q?6JZwCQhfYpwK4kiBGZT8fngGcubnZCzFtWA4EFxFfkq63seo4rzbC8fGoZpD?= =?us-ascii?Q?zQFYjHcv6ZIdtNRLIgP+fcO4jVG4+hvB4Ceo/muIFVT1xrQo7ToDdPAFM6MP?= =?us-ascii?Q?nQQoS0wJQ05WNVNpSMrR2kfjdPO1pyAzhAxzjSpP1rDgmjfem2NcBYsw6SBm?= =?us-ascii?Q?0RtzfIjTdxcfn9+wBcoDt+kXriSYL7EpHvYLPMH5MBWSuKVkDhkA8WQjywoP?= =?us-ascii?Q?aGKZOnQromsCd5I4BcAPICptimExIRBgry3Q5EsVepXqKjSjfvfZAzQwSKLW?= =?us-ascii?Q?7zbcpjR/9wt0kdxc69kq/QYCiqzs9U8c1UDw+qRIqWhpqcDqkreR19hPVF3d?= =?us-ascii?Q?ENVuCN1O2fT+doBpqCQDeDf34VkXqDE1bIg+EdiwUKIcXo4Bd8CJbzgoa1v8?= =?us-ascii?Q?PO81UrawclhKio6NB+vjAaR7Y8Wa+zvJB34efeS+wEq3j63CoEqt46Sg55Ks?= =?us-ascii?Q?SFbnl0fwdQcIoojZ7M0G76bFvIxqCDYT7GP7w3HLPgoWxGDT2zEN/L/MRbb1?= =?us-ascii?Q?J0TYUHpiIdZu5tB0Np8j2R28tA1PKFdZ9ktz5OiNbFsb5TE7LkFGV3G6Hlpl?= =?us-ascii?Q?AAdh8eshp/wvRKOihV5442d60q4gnAcljlTJUkPE2mmjmrgQSKAwYCEC+CVE?= =?us-ascii?Q?dZomqXhlcr4MNv5vb3tf3iRW7UlAH5xhiW3HssxlbPlvwMfYCiMLX5K5JbhK?= =?us-ascii?Q?xuQb0NflVuWansBvgRV701xpVrS40Tu1CHGy2jRHoc4Nf7Nn8p4yfsqrfxKZ?= =?us-ascii?Q?lObBCqFaSc8a2NyTpOG3hJzo71E0vCZAw7mauoI1qaggGg3FBUrVEbdo/TA0?= =?us-ascii?Q?OWpa5W+kpaaY7LTckbOb3XV3KDCGVqi2P4GB2/zM?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e0c013e-6ba9-4d46-53b6-08dc2218ac05 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 04:54:14.4220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SXqfl7XBd3a7j2FEyHVLkK2gwNEycz/o44EvVz0BV76lR9ymnBVyDGSEedg1TLCvzwmmNTv9fQ3wqJxqjtpl2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8304 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: e5zaUrtbRXNNUZIvpEcS3Ykex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ReMXVJ8P; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi All, =C2=A0=C2=A0=C2=A0 Thanks for reviewing the patch, I had re-based the patc= h and added=20 "Acked-by". Please take a look and merge the PR. https://github.com/tianocore/edk2/pull/5269 Thanks AbduL On 25-01-2024 21:51, Tom Lendacky wrote: > On 1/25/24 04:20, Ni, Ray via groups.io wrote: >> Acked-by: Ray Ni >> >> + Tom > > Looks good to me. Should AmdGetProcessorLocation2ByApicId() be STATIC? [Abdul] I think its okay to not have STATIC, as I can see other local=20 functions also doesn't have STATIC prefix. > > Not asking for this patch series, but there is a lot of duplicated=20 > code between the two APIC libraries. It would be nice if there was a=20 > way to have a common file where just a single copy of the duplicated=20 > code could live. [Abdul] Agree lot of duplicate code, we can combine BaseXApic and=20 BaseXApicX2Apic library to single library and have separate INF file=20 with shared source file. > > Acked-by: Tom Lendacky > > Thanks, > Tom > >> >> Thanks, >> Ray >>> -----Original Message----- >>> From: Attar, AbdulLateef (Abdul Lateef) >>> Sent: Thursday, January 25, 2024 1:02 PM >>> To: devel@edk2.groups.io >>> Cc: Kinney, Michael D ; Liming Gao >>> ; Liu, Zhiguang ; Ni, >>> Ray ; Kumar, Rahul R ; Gerd >>> Hoffmann >>> Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended >>> topology >>> >>> Gentle reminder, please review the patch series. >>> >>> On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote: >>>> Caution: This message originated from an External Source. Use proper >>> caution when opening attachments, clicking links, or responding. >>>> >>>> >>>> From: Abdul Lateef Attar >>>> >>>> Resending the patch with updated Cc list. >>>> >>>> PR: https://github.com/tianocore/edk2/pull/5269 >>>> >>>> V2: delta changes >>>> =C2=A0=C2=A0 - Added additional check apart from supported CPUID extne= ded=20 >>>> number. >>>> =C2=A0=C2=A0 - removed EFIAPI >>>> >>>> Implements AMD extended toplogy. >>>> Adds CPUID macro >>>> update APIC library to use new exteded cpuid. >>>> >>>> Cc: Michael D Kinney >>>> Cc: Liming Gao >>>> Cc: Zhiguang Liu >>>> Cc: Ray Ni >>>> Cc: Rahul Kumar >>>> Cc: Gerd Hoffmann >>>> Cc: Abdul Lateef Attar >>>> >>>> Abdul Lateef Attar (2): >>>> =C2=A0=C2=A0=C2=A0 MdePkg: Adds AMD Extended CPU topology CPUID >>>> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD ext= ended cpu >>> topology >>>> >>>> =C2=A0=C2=A0 MdePkg/Include/Register/Amd/Cpuid.h=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 23 +++- >>>> =C2=A0=C2=A0 .../Library/BaseXApicLib/BaseXApicLib.c=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | 126 >>> +++++++++++++++++- >>>> .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c=C2=A0=C2=A0 | 126 >>> +++++++++++++++++- >>>> =C2=A0=C2=A0 3 files changed, 272 insertions(+), 3 deletions(-) >>>> >>>> --=20 >>>> 2.34.1 >>>> >>>> >>>> >>>> >>>> >>>> >> >> >>=20 >> >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114856): https://edk2.groups.io/g/devel/message/114856 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-