Re: [PATCH v3 0/6] Add BhyvePkg, to support the bhyve hypervisor

["Laszlo Ersek" <lersek@redhat.com>]

On 04/21/20 17:38, Rebecca Cran wrote:
> On 4/21/20 9:27 AM, Laszlo Ersek wrote:
> 
>>
>> (1) For example, I can't find the patch that adds
>> "BhyvePkg/BhyvePkgX64.dsc", in spite of the file being listed in the
>> cumulative diffstat below.
> 
> That's in the "Add BhyvePkg" patch.

I'm very sorry; for some reason, I don't have your v3 4/6 patch in my
list folder, nor my INBOX! I don't understand why. I can see the patch
in at least one mailing list archive.

> 
>> (2) I also don't really understand why v2 / v3 have been posted, given
>> that the bhyve-specific ResetSystemLib instance that I suggested under
>> v1, based on your proposed code, still depends on the ResetSystemLib
>> cleanup series that I posted. The idea is that you would base the new
>> bhyve ResetSystemLib instance on my ResetSystemLib refactoring.
> 
> Since the changes to ResetSystemLib aren't required for this series and
> will require rework, I removed them.
> 
>> Because my series has not been merged yet, for such a bhyve rebase you'd
>> have to pick up my patches from the list temporarily. That's a 100%
>> usable approach, but then, this v3 series of yours does not seem to
>> introduce *any* ResetSystemLib instance. Have you decided to postpone
>> that work for later?
> 
> 
> Sorry, yes I have decided to postpone those changes since as you say I'd
> need to pick up your patches from the list.

OK, that makes sense -- but, without the ResetSystemLib instance, are
you able to boot the BhyvePkg platform firmware in a bhyve guest? Does
(for example) the "reset -c" UEFI Shell command work?

>> In the end, please wait until I get around merging the ResetSystemLib
>> refactoring <https://bugzilla.tianocore.org/show_bug.cgi?id=2675>.
> 
> I'd prefer not to, since introducing BhyvePkg doesn't depend on the
> ResetSystemLib changes. Could this series not be committed, then a
> subsequent commit be made to use the ResetSystemLib changes?

Yes, this ordering makes 100% sense -- assuming your v3 series passes
review and is *functional enough*.

Does the ResetSystem runtime service work, in v3?

Thanks!

(And I'm sorry about my slow responses, it's... difficult. :/)

Laszlo