From: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Nhi Pham <nhi@os.amperecomputing.com>,
devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Rebecca Cran <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 4/4] SbsaQemu: disable XHCI in DSDT if not present
Date: Wed, 18 Oct 2023 12:08:20 +0200 [thread overview]
Message-ID: <18b327d0-4905-4687-8284-c899269f746b@linaro.org> (raw)
In-Reply-To: <CAMj1kXFRjhtcKAShMOh5-oJkwjbrD4oLxhvQ+iBooRWyu_qR8g@mail.gmail.com>
W dniu 18.10.2023 o 10:47, Ard Biesheuvel pisze:
>>> Nit: EDK2 Coding Style says that you need a space before (.
>> Ah, right. forgot to crucify the source.
>>
>>> Is it necessary to handle the result of Status?
>> EDK2 is full of handling Status on touching ACPI tables. So I followed.
>>
> Can you just do 'return DisableXhciOnOlderPlatVer();' instead?
Done. Sent v4.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109724): https://edk2.groups.io/g/devel/message/109724
Mute This Topic: https://groups.io/mt/102017316/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-18 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 13:23 [edk2-devel] [PATCH edk2-platforms v3 0/4] Provide XHCI USB controller only for newer hardware Marcin Juszkiewicz
2023-10-17 13:23 ` [edk2-devel] [PATCH edk2-platforms v3 1/4] SbsaQemu: introduce macro to compare platform version Marcin Juszkiewicz
2023-10-18 8:45 ` Ard Biesheuvel
2023-10-18 8:46 ` Ard Biesheuvel
2023-10-18 10:10 ` Marcin Juszkiewicz
2023-10-17 13:23 ` [edk2-devel] [PATCH edk2-platforms v3 2/4] SbsaQemu: add AcpiLib Marcin Juszkiewicz
2023-10-17 13:23 ` [edk2-devel] [PATCH edk2-platforms v3 3/4] SbsaQemu: initialize XHCI only if it exists Marcin Juszkiewicz
2023-10-17 13:23 ` [edk2-devel] [PATCH edk2-platforms v3 4/4] SbsaQemu: disable XHCI in DSDT if not present Marcin Juszkiewicz
2023-10-18 3:28 ` Nhi Pham via groups.io
2023-10-18 5:56 ` Marcin Juszkiewicz
2023-10-18 8:47 ` Ard Biesheuvel
2023-10-18 10:08 ` Marcin Juszkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18b327d0-4905-4687-8284-c899269f746b@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox