From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4C84E9410EB for ; Wed, 18 Oct 2023 10:08:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=N/6mh96R4RD27Mi4jDZRPquE6XtP6o/Nj6n6I11UfSw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697623705; v=1; b=pO4YWwB2pcWbb97hOBGV04w6qtW0t3GtKGwRI1NDUQWkN8B3RfyY4D0jXgeOHETVe0ynORtW PmFRCyyzJt7OulmT+iPnJP6rL5/arBzz138oAj9YdCOKcMjFzgGysx1U3tR/E4+FMbt1iQgHC/w 7R4KWo6qxp3Ckk3eZWhMKRn0= X-Received: by 127.0.0.2 with SMTP id IpKNYY7687511xg2sEtsdZXk; Wed, 18 Oct 2023 03:08:25 -0700 X-Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by mx.groups.io with SMTP id smtpd.web11.277797.1697623704411709610 for ; Wed, 18 Oct 2023 03:08:24 -0700 X-Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-45600aceffbso2561521137.0 for ; Wed, 18 Oct 2023 03:08:24 -0700 (PDT) X-Gm-Message-State: id39ZiiCfbdIczaoyOCaT79wx7686176AA= X-Google-Smtp-Source: AGHT+IHUKhdKRmm6l8kkptY+KfueQr+a+v/gaiRGLWHfQJ/ZEInO6tfSHs0qMv6Cs9szVMxd1yCF8Q== X-Received: by 2002:a67:a249:0:b0:457:c57c:ef13 with SMTP id t9-20020a67a249000000b00457c57cef13mr4761533vsh.31.1697623703442; Wed, 18 Oct 2023 03:08:23 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.27.172.ipv4.supernova.orange.pl. [83.11.27.172]) by smtp.gmail.com with ESMTPSA id d22-20020a67e116000000b0045255981807sm437373vsl.0.2023.10.18.03.08.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 03:08:23 -0700 (PDT) Message-ID: <18b327d0-4905-4687-8284-c899269f746b@linaro.org> Date: Wed, 18 Oct 2023 12:08:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 4/4] SbsaQemu: disable XHCI in DSDT if not present To: Ard Biesheuvel Cc: Nhi Pham , devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Jeremy Linton , Chuong Tran , Rebecca Cran References: <20231017-ehci-xhci-fix-v3-0-0b9ec9847947@linaro.org> <20231017-ehci-xhci-fix-v3-4-0b9ec9847947@linaro.org> <57236818-8e59-4da0-af38-4809d08fba7f@os.amperecomputing.com> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pO4YWwB2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 18.10.2023 o 10:47, Ard Biesheuvel pisze: >>> Nit: EDK2 Coding Style says that you need a space before (. >> Ah, right. forgot to crucify the source. >> >>> Is it necessary to handle the result of Status? >> EDK2 is full of handling Status on touching ACPI tables. So I followed. >> > Can you just do 'return DisableXhciOnOlderPlatVer();' instead? Done. Sent v4. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109724): https://edk2.groups.io/g/devel/message/109724 Mute This Topic: https://groups.io/mt/102017316/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-