From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, chasel.chiu@intel.com
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>,
Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [PATCH 2/2] IntelFsp2WrapperPkg: Remove CI exception of PlatformMultiPhaseLib.
Date: Tue, 4 Oct 2022 23:07:00 -0400 [thread overview]
Message-ID: <18bb7e62-1864-aa0f-0820-6a28f1bb173e@linux.microsoft.com> (raw)
In-Reply-To: <20221005012219.1850-3-chasel.chiu@intel.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 10/4/2022 9:22 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
>
> Duplicate library class header issue will be resolved and CI
> exception for FspWrapperPlatformMultiPhaseLib should be removed too.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> index 6788a723a1..45cb5a7d6f 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> @@ -78,11 +78,7 @@
>
>
> ## options defined .pytool/Plugin/LibraryClassCheck
>
> "LibraryClassCheck": {
>
> - "IgnoreLibraryClass": [
>
> - # This header file contains a small function in a separate library so platforms
>
> - # do not have to override the whole main library instance.
>
> - "FspWrapperPlatformMultiPhaseLib"
>
> - ]
>
> + "IgnoreLibraryClass": []
>
> },
>
>
>
> ## options defined .pytool/Plugin/SpellCheck
>
prev parent reply other threads:[~2022-10-05 3:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 1:22 [PATCH 0/2] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib Chiu, Chasel
2022-10-05 1:22 ` [PATCH 1/2] " Chiu, Chasel
2022-10-05 1:22 ` [PATCH 2/2] IntelFsp2WrapperPkg: Remove CI exception of PlatformMultiPhaseLib Chiu, Chasel
2022-10-05 3:07 ` Michael Kubacki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18bb7e62-1864-aa0f-0820-6a28f1bb173e@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox