Re: [PATCH v3 1/1] MdePkg: Use ANSI colors to indicate debug message severity

["Rebecca Cran" <quic_rcran@quicinc.com>]

On 9/6/22 12:40, Kinney, Michael D wrote:
> Rebecca,
>
> BasePrintLib is used for much more than just DEBUG() macros.  This features should
> not modify the behavior of BasePrintLib.
>
> For example, a single module that links to BasePrintLib can use those services
> for non DebugLib services with no expectation that ANSI sequences are added
> and that same module can link against DebugLib for DEBUG() macro support that
> expects ANSI sequences to be added.  This is a conflict.
>
> The scope of this change should be only the DebugLib instance.

The reason I put the functions in BasePrintLib is because I couldn't see 
any other common location to put them.

But since one deals with Unicode and the other ASCII, I think defining 
them in their respective libraries might be fine, since we won't end up 
duplicating code.


>>   [PcdsFeatureFlag]
>>     gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|TRUE
>> +  gEfiMdePkgTokenSpaceGuid.PcdDebugAnsiSeqSupport|FALSE
> The DEC default value is FALSE, so this line is not required.

Thanks, I'll fix it in the next patch version.

-- 
Rebecca Cran