From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web09.612.1662501728713895294 for ; Tue, 06 Sep 2022 15:02:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=J6NK7dPC; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 286LnVxT015314; Tue, 6 Sep 2022 22:01:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=UkIMtA6FA5+UcoNKArLR3JnFzyH6fpnmyUzR4SK0mrs=; b=J6NK7dPCIFcF4JEOxLupr3SbFvjxAfkp+ZN/WUovIPSDQv8q0Kuv3F+IsL96Jo7SMU2J alYWBrp5sI2kdIp6SPvlXDRJfrVUPkDoVEmT6wziP339VkVJbRXw8uEwEWStv+Y6ZLsf ArtyiBonOJGg0ZmUgMKIL2noK0VAZXnXWDaAHDsqj3W89z/tHER5ydCn7U2412Hf5tic O7XoYYz5VqJXPKbcdGJKIZAeqfqJC7//0U5pSmH0G/iqBy7l6fur592zAaiWyyJ3QuzO HEWrtPHyRRlVK5CqAs9nycNILlL+2zR8fCXGRX2IrNDiL7JwLV2IQK04mAbdGtNWbrlu vg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jdys739uy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Sep 2022 22:01:56 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 286LpivU008094 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Sep 2022 21:51:44 GMT Received: from [10.110.11.216] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 6 Sep 2022 14:51:44 -0700 Message-ID: <18be95c4-15ea-4e4c-3638-3357293b0bcd@quicinc.com> Date: Tue, 6 Sep 2022 15:51:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 1/1] MdePkg: Use ANSI colors to indicate debug message severity To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Gao, Liming" , "Liu, Zhiguang" , Andrew Fish References: <20220902112322.203555-1-rebecca@quicinc.com> <20220902112322.203555-2-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GbYeKR9MgeV3V01urTjEDKsh1-f8tmsP X-Proofpoint-ORIG-GUID: GbYeKR9MgeV3V01urTjEDKsh1-f8tmsP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-06_09,2022-09-06_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 bulkscore=0 mlxlogscore=997 phishscore=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209060103 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 9/6/22 12:40, Kinney, Michael D wrote: > Rebecca, > > BasePrintLib is used for much more than just DEBUG() macros. This features should > not modify the behavior of BasePrintLib. > > For example, a single module that links to BasePrintLib can use those services > for non DebugLib services with no expectation that ANSI sequences are added > and that same module can link against DebugLib for DEBUG() macro support that > expects ANSI sequences to be added. This is a conflict. > > The scope of this change should be only the DebugLib instance. The reason I put the functions in BasePrintLib is because I couldn't see any other common location to put them. But since one deals with Unicode and the other ASCII, I think defining them in their respective libraries might be fine, since we won't end up duplicating code. >> [PcdsFeatureFlag] >> gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|TRUE >> + gEfiMdePkgTokenSpaceGuid.PcdDebugAnsiSeqSupport|FALSE > The DEC default value is FALSE, so this line is not required. Thanks, I'll fix it in the next patch version. -- Rebecca Cran