From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.13853.1589209585875559279
 for <devel@edk2.groups.io>;
 Mon, 11 May 2020 08:06:26 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78E9AD6E;
	Mon, 11 May 2020 08:06:25 -0700 (PDT)
Received: from [192.168.1.81] (unknown [10.37.8.255])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AC7F3F68F;
	Mon, 11 May 2020 08:06:24 -0700 (PDT)
Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 3/4] Silicon/AsixPkg: Add ASIX Ax88179 driver
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ray Ni <ray.ni@intel.com>, Leif Lindholm <leif@nuviainc.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com>
 <20200510111530.26225-4-Samer.El-Haj-Mahmoud@arm.com>
 <e1664747-96bc-38b6-62af-030d1f6c7a24@arm.com>
 <DB7PR08MB3260D27C755F0D4EAAABB4C390A10@DB7PR08MB3260.eurprd08.prod.outlook.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <18ca4bbc-2413-0eca-6327-bda685b3d07c@arm.com>
Date: Mon, 11 May 2020 17:06:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <DB7PR08MB3260D27C755F0D4EAAABB4C390A10@DB7PR08MB3260.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 5/11/20 5:04 PM, Samer El-Haj-Mahmoud wrote:
> Thanks Ard for the review. The cosmetic/code style changes are easy enough. For the other changes, I will need to test to make sure everything still works. I guess I will have to order an Ax88179 adapter...
> 

I have one here

Bus 004 Device 003: ID 0b95:1790 ASIX Electronics Corp. AX88179 Gigabit 
Ethernet


but I haven't tried it with this driver yet.