Re: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 12/6/19 5:09 PM, Rabeda, Maciej wrote:
> Philippe,
> 
> I was so keen to give you the green light but typo in Callback.c has not been fixed here.
> ususlly -> ususally

Nice catch!

> If you could address this, that would be great :)

Certainly, will do.

> Thanks!
> Maciej
> 
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Tuesday, December 3, 2019 17:16
> To: devel@edk2.groups.io
> Cc: Antoine Coeur <coeur@gmx.fr>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos
> 
> From: Antoine Coeur <coeur@gmx.fr>
> 
> Fix few typos in comments and documentation.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>   NetworkPkg/SnpDxe/Snp.h           | 8 ++++----
>   NetworkPkg/SnpDxe/Callback.c      | 2 +-
>   NetworkPkg/SnpDxe/Shutdown.c      | 2 +-
>   NetworkPkg/SnpDxe/Snp.c           | 6 +++---
>   NetworkPkg/SnpDxe/WaitForPacket.c | 2 +-
>   5 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/NetworkPkg/SnpDxe/Snp.h b/NetworkPkg/SnpDxe/Snp.h index 9e4b7d6f86a0..66b5f948e27c 100644
> --- a/NetworkPkg/SnpDxe/Snp.h
> +++ b/NetworkPkg/SnpDxe/Snp.h
> @@ -1,5 +1,5 @@
>   /** @file
> -    Declaration of strctures and functions for SnpDxe driver.
> +    Declaration of structures and functions for SnpDxe driver.
>   
>   Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
>   SPDX-License-Identifier: BSD-2-Clause-Patent @@ -289,7 +289,7 @@ SnpUndi32CallbackBlock (
>     @param UniqueId      This was supplied to UNDI at Undi_Start, SNP uses this to
>                          store Undi interface context (Undi does not read or write
>                          this variable)
> -  @param MicroSeconds  number of micro seconds to pause, ususlly multiple of 10.
> +  @param MicroSeconds  number of micro seconds to pause, usually multiple of 10.
>   **/
>   VOID
>   EFIAPI
> @@ -378,7 +378,7 @@ SnpUndi32CallbackUnmap (
>     need to synchronize their contents whenever it writes to/reads from the buffer
>     using either the cpu address or the device address.
>   
> -  EFI does not provide a sync call, since virt=physical, we sould just do
> +  EFI does not provide a sync call, since virt=physical, we should just
> + do
>     the synchronization ourself here!
>   
>     @param UniqueId    This was supplied to UNDI at Undi_Start, SNP uses this to store
> @@ -1015,7 +1015,7 @@ SnpUndi32Receive (
>     );
>   
>   /**
> -  Nofication call back function for WaitForPacket event.
> +  Notification call back function for WaitForPacket event.
>   
>     @param  Event       EFI Event.
>     @param  SnpPtr      Pointer to SNP_DRIVER structure.
> diff --git a/NetworkPkg/SnpDxe/Callback.c b/NetworkPkg/SnpDxe/Callback.c index 6387dbdb35ef..babfca7d76c7 100644
> --- a/NetworkPkg/SnpDxe/Callback.c
> +++ b/NetworkPkg/SnpDxe/Callback.c
> @@ -53,7 +53,7 @@ SnpUndi32CallbackBlock (
>     @param UniqueId      This was supplied to UNDI at Undi_Start, SNP uses this to
>                          store Undi interface context (Undi does not read or write
>                          this variable).
> -  @param MicroSeconds  Number of micro seconds to pause, ususlly multiple of 10.
> +  @param MicroSeconds  Number of micro seconds to pause, ususally multiple of 10.
>   
>   **/
>   VOID
> diff --git a/NetworkPkg/SnpDxe/Shutdown.c b/NetworkPkg/SnpDxe/Shutdown.c index aad0fe8493a8..ae823fd35243 100644
> --- a/NetworkPkg/SnpDxe/Shutdown.c
> +++ b/NetworkPkg/SnpDxe/Shutdown.c
> @@ -1,5 +1,5 @@
>   /** @file
> -    Implementation of shuting down a network adapter.
> +    Implementation of shutting down a network adapter.
>   
>   Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
>   SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/NetworkPkg/SnpDxe/Snp.c b/NetworkPkg/SnpDxe/Snp.c index 1099dbfa6a28..078b27cf5edd 100644
> --- a/NetworkPkg/SnpDxe/Snp.c
> +++ b/NetworkPkg/SnpDxe/Snp.c
> @@ -782,7 +782,7 @@ SimpleNetworkDriverStop (
>   
>     if (PcdGetBool (PcdSnpCreateExitBootServicesEvent)) {
>       //
> -    // Close EXIT_BOOT_SERIVES Event
> +    // Close EXIT_BOOT_SERVICES Event
>       //
>       gBS->CloseEvent (Snp->ExitBootServicesEvent);
>     }
> @@ -840,9 +840,9 @@ EFI_DRIVER_BINDING_PROTOCOL gSimpleNetworkDriverBinding = {
>     @param ImageHandle       The driver image handle.
>     @param SystemTable       The system table.
>   
> -  @retval EFI_SUCEESS      Initialization routine has found UNDI hardware,
> +  @retval EFI_SUCCESS      Initialization routine has found UNDI hardware,
>                              loaded it's ROM, and installed a notify event for
> -                           the Network Indentifier Interface Protocol
> +                           the Network Identifier Interface Protocol
>                              successfully.
>     @retval Other            Return value from HandleProtocol for
>                              DeviceIoProtocol or LoadedImageProtocol diff --git a/NetworkPkg/SnpDxe/WaitForPacket.c b/NetworkPkg/SnpDxe/WaitForPacket.c
> index 866a1e8c0e8c..c337e69290f9 100644
> --- a/NetworkPkg/SnpDxe/WaitForPacket.c
> +++ b/NetworkPkg/SnpDxe/WaitForPacket.c
> @@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>   
>   
>   /**
> -  Nofication call back function for WaitForPacket event.
> +  Notification call back function for WaitForPacket event.
>   
>     @param  Event       EFI Event.
>     @param  SnpPtr      Pointer to SNP_DRIVER structure.
> --
> 2.21.0
> 
> --------------------------------------------------------------------
> 
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> 
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
> przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
>