From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.63]) by mx.groups.io with SMTP id smtpd.web08.15125.1638979812403911711 for ; Wed, 08 Dec 2021 08:10:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=H/JMnhbL; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.101.63, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHUxU5lXsKQ0LM1aoVdrH2jRTjnN7g+WgvjozAXGsVpSQtBUQhTeT2dEpr6CZ/YzXcS1ebw2sBXCdT0G/qmj0W7yu7+JrdnDA9SiVHV9dOSj5GjJaslSJ4XsXHGEkU+yu3U1S0kPQ7FIJdnVcLuibheWRAIsyQ+tQ0K3Oq3DpkPubMVguShNwtAUlED709wbbcnCL/1H2zZzGtnuB5cAJ3zrV0fus5km9IsxmQRtyGw/+HQo8ElrjWnGclp7YVW7kZsKJzZiC59qAQPzTaNObV94B7fgJlAxUGe1IXauey7RqeH0DJI+68Ijr6YJD6mjhww7jGT3/Oc/bV0QMc2ahQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=61ZuU+zJTR34903UKGsfE5WXXJJJslrllmVizVKT7Js=; b=GmQN9jRe9+ON7ttMRveDynYap90wmN7eQhQSwRVobrUyGhftGa2JPlkcmOgd65OOSKbSD8+UTRdNOW7NymBt6YIWnsjlRReSpVnjJiUxyxALFhuAwaSCfXaL5ig0AVq0G1B3hJ/NDCu2lMnEhTTKXcbpg7DYCJbiVcvbj/4IVY/1Kgw/W9Nck8dtZI/z/3uRTlGmsJoosyPgIN/6jbPB4xQB1QbkxMNJyLw/Jcy9KuOMGUh8v3NzUzbdBpZtRBYjeuoWz1wRvktt//E62Kk7XDcpcKbhFCpUpCRnRp89d13khzuQASIRDw6RiN7XhO8Jc3s4iNa2WroHpndRnkNcbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61ZuU+zJTR34903UKGsfE5WXXJJJslrllmVizVKT7Js=; b=H/JMnhbL56Mzl+VzFxYEZjvKcOBy8MZp46LO4bDJt/zPqQWjb1MsteZ3J5zUVz4stGXYfnuczcZqlVksZNvlK0pxbVnOVtFJkon3OYFMs5yDu27VzebqXbyPJXdDkZ4v1975t0zJZyOAcg+38E4IKOVHD+jFZ28A3TM+uH6yjeI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4574.namprd12.prod.outlook.com (2603:10b6:806:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Wed, 8 Dec 2021 16:10:10 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c%6]) with mapi id 15.20.4755.021; Wed, 8 Dec 2021 16:10:09 +0000 CC: brijesh.singh@amd.com Subject: Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" References: <8bb9a4b2-2e04-62df-f688-9b6357091d21@amd.com> From: "Brijesh Singh" Message-ID: <18d2cc3b-9b31-3d8a-29b4-a0f888fd9afc@amd.com> Date: Wed, 8 Dec 2021 10:10:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <8bb9a4b2-2e04-62df-f688-9b6357091d21@amd.com> X-ClientProxiedBy: CH2PR19CA0011.namprd19.prod.outlook.com (2603:10b6:610:4d::21) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from [10.236.30.107] (165.204.77.1) by CH2PR19CA0011.namprd19.prod.outlook.com (2603:10b6:610:4d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Wed, 8 Dec 2021 16:10:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4079191-518d-4dda-ab6d-08d9ba653509 X-MS-TrafficTypeDiagnostic: SA0PR12MB4574:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /4hDsClDx9eJTr2/dQv+YmVytR/DAtaVFcsGqJfc+Ha2MeIR2MzsZ5QZ9i6KHJ5KcLeQY1NSXXHIQTaPkSLvzxZBrvNUwfGvj2M/OzwqYxkJVBFtP0UqubABS8QWICdq55L6wC0pPI9VIh3q7J+0e9COBWST8SgoPe0qEhbxdm4/8yLdudDQn9g2y4R3RCVtDujB5R00A99q58M4P3h+DOyGqf0Yr7m9ZFfgljTFdDvV/wAO2/cNCnaQumqLilbYdyvzzFFImnXjO4lc02YrxLF3kMpeTY3PPk9xQm7yTNLvOVUJJjm/PGtFOE4pILxIDn2q30qVHk9w1Hy5hWUjo2tLXslEkjH0LesNJR3eRO95aEv/GBYP5goa/r7pUQHBFUkecW712+U9yR0B2fkQ65fzihjTVatDSG1BuyVtQ4QJcIc7fy724RAh21Gf9LX8RqlhRnwgEqAo7XeqL+p4Qlv5/+vax1H1WYrktiAx7Febr7sQXxsLFqzCYl1naumjaTh2Phdlg85kh8qkLCElLtcxqjMAGCekktf4mBRpuOuGqrGdt5ymcjHf9EDOK4LVzhIcs+vHzHtJfBBycjWo8fF+ZDQGYe864OfT11MWhtKJSLHnYCnOsuX4PzUOjusnEhpyWjjEOwXzlnzhM6t1x1AXUrori07fxEFjSQhNH5BPffSAY4SwiQ+sk98i1tTGFw5miidCaINZYOmAm+6t+Pek/tbL+7swALsuDoV0yASOD5uaVlNEc6ijpMt8JWQR8lWqlsoWXlfFjIDllzCWSdgWqNbNVhZekNw69y6hpakRba397YSvBY/evzZjq6gMMVQMsQgMzmQ6PolLLL3QDFsOBN03u3/mNmuR5lDXNvE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(86362001)(2616005)(44832011)(83380400001)(4326008)(6486002)(956004)(66946007)(16576012)(38100700002)(316002)(110136005)(31686004)(5660300002)(8936002)(66476007)(36756003)(508600001)(966005)(66556008)(2906002)(53546011)(8676002)(186003)(26005)(43740500002)(45980500001)(460985005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AJRRGfeTJfKw4cmpWGAQuhCUmG6LU5eSmG6wNzTi9bqmgZFl5texqz5JXJvS?= =?us-ascii?Q?hTRaod3JFUjDmz+35XqLIUkwEy4T4E+9VsvU4u4wSINOUI9/Q0di4xnj1B5K?= =?us-ascii?Q?WQuUDGCNdn1PWXbxyJqm6w/X5O+53mKIrKGQ8fTiEXML7/+y/rsEsVKm74n4?= =?us-ascii?Q?Suqw8o+72MunnI5rBcqc4Ko77srKDJGMqIHEUZ9TVRzAyCLy0ytYEuPSdejX?= =?us-ascii?Q?/O7e7ePOR0dUVtTybqDfMjVlSnXDRnbvRSdkKHHukDtWzruBUGTfG0lqcmuI?= =?us-ascii?Q?spzOP6nU78XuQNUSqvPgt3bspJbkDt5JPcMExAMoHf4DECTo0WYeVVYMOIiv?= =?us-ascii?Q?AVl1Iev+JBVckw7bqvaysQpjsj01YMznq37S6OBc/s2ti4DhC24f4NZ/XGDS?= =?us-ascii?Q?xSx7/5Dbw6c8uS/HOCtdIagxZ+5uYX0A7LcQQcyINTMxP3sstK0e63wUH33e?= =?us-ascii?Q?cIzQcXi3J71J6JydfzxImoNxGNu1MeCHB5kDWJ5wGvJT1P49/FKnmh17GZf+?= =?us-ascii?Q?JLcZpkd/NTcmi4cZw/6c77/fC9P+AmAIGjjD3W1hA3cMbuCdSY9QOt7fMzo2?= =?us-ascii?Q?AfhAbCD1oo+FIpa9RvTlpII3NbLmSc5EFmc04C4GEJm7f0WXzFRrhvBIH7bJ?= =?us-ascii?Q?xIcMrqpc0eJh8VIZafA1KB4NB1tK7Z+FELkI9QR6boj2OjFe5/IFAS8hNTvP?= =?us-ascii?Q?Ec+yL2mRhK+zo4ozfY+xdkSLAyo/Q9EMCaDL5Q3dOCt9N0CqEdmsPnnIraUV?= =?us-ascii?Q?/zxi43Mzs3GCuol7IZiELm7PIRY472SLx5J9CS5eTZ/4IY0XjoKLmbAKHY+/?= =?us-ascii?Q?Ob2HwvifNbA76fZQkBI/G0fRMxyaY1URqqasCB7Gtkyv9Ae7ZI3Lwkf34ze4?= =?us-ascii?Q?s9tVW9NHM8CiZNyU5mHBc4okiSIMKSTlcTDVCvqvpDt3Pvi6soXXtKU+VgFW?= =?us-ascii?Q?0vKFg2v4wa8zYZvlahcv6ZGNyvmwEwZvgtiXYPdee9sCA+1IfAIPdjeYEr+Q?= =?us-ascii?Q?EqwolFxfGY9ux1aIQKXAV0pxnhxPNWmArhVOB2yLw1wqAsgemsoTxDQ5NN+Z?= =?us-ascii?Q?IOjsdseXdQw/PyOqFr1Z59OIn5AVAw+TLp5oZ/uK3GWXxoW3JU0/rToATzCd?= =?us-ascii?Q?QTypADA3uS1h6DuXIEOKw76rE5Mcp4H1JVQV/u/EAlJC37oJnlua2g+BgZrJ?= =?us-ascii?Q?1kn3cFkcBLwAMHpzjgXYhQsLhc9ijBDLGfE2Giip7CBBQzBxWSSaDSF9g+/H?= =?us-ascii?Q?HclSDwwNJkmPjYIDTwIYSLVsFhoLcZyMPE174/aFeigq1k9mXgnZEl+4g693?= =?us-ascii?Q?elPtGAeQNBdXjSdLeIDFvI9aGlzss690cyu4d6ne1mkybQ2XkeMXtc67zcG5?= =?us-ascii?Q?a+I2KPwETmtWTw40qyWLftIhXziqWRyuWpz/6MSdkbMENCV3nZWWe8dOAi/Y?= =?us-ascii?Q?7fhOzKgOR79qTbCFpo5nZdj+cN81VvSbclDiy24NJTxFu/AS0qUCMFDMnGJV?= =?us-ascii?Q?5VYY6HCTDoAfAODtxfnCBfjnVbd4mg6niBHaSoQY4aQEGh7SciuSg9Mg3yl0?= =?us-ascii?Q?qhBh4inlVXndJWoafMKb0QieSa3Kf9MhS4E+IBd1x4MvHpuP9QyiN6Jdu2Zf?= =?us-ascii?Q?Z/y5VqlfucYbtniA0EoTX1s=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4079191-518d-4dda-ab6d-08d9ba653509 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 16:10:09.7533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mhVTa7GwK8wv8kf1prFbUfqV7hcz1i6+UoVBCCm3rU7LmH3+8RPuGc+4ENET1w67aKt2XzG+nRkix1VZqQzyJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4574 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/8/21 8:39 AM, Brijesh Singh wrote: ... >> OvmfPkg Example: >> >> =C2=A0=C2=A0=C2=A0=C2=A0 git ls-files OvmfPkg/*.c OvmfPkg/*.h :!BaseTool= s/* |=20 >> .pytool\Plugin\UncrustifyCheck\mu-uncrustify-release_extdep\Windows-x86\= uncrustify.exe=20 >> -c .pytool\Plugin\UncrustifyCheck\uncrustify.cfg -F - --replace=20 >> --no-backup --if-changed >> >> >=20 > Thanks for the detail, I just did a pull and now I see the uncrustify=20 > cfg files. I followed your above command on my Ubuntu desktop and=20 > getting the below unknown symbol, is this a known issue ? >=20 >=20 > brijesh@sbrijesh-desktop:~/workdir/snp-edk2$ git ls-files=20 > OvmfPkg/Sec/AmdSev.c | uncrustify -c=20 > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F - --replace --no-backup= =20 > --if-changed > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:73: unknown symbol=20 > 'nl_func_call_args_multi_line_ignore_closures' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:79: unknown symbol=20 > 'indent_func_call_edk2_style' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:120: unknown symbol=20 > 'sp_do_brace_open' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:134: unknown symbol=20 > 'sp_before_vardef_square' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:178: unknown symbol=20 > 'sp_brace_close_while' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:184: unknown symbol=20 > 'sp_before_square_asm_block' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:205: unknown symbol=20 > 'sp_while_paren_open' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:229: unknown symbol=20 > 'indent_func_def_param_paren_pos_threshold' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:270: unknown symbol=20 > 'align_edk2_style' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:323: unknown symbol=20 > 'cmt_align_doxygen_javadoc_tags' > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg:406: unknown symbol=20 > 'nl_before_whole_file_ifdef' > Parsing: OvmfPkg/Sec/AmdSev.c as language C > brijesh@sbrijesh-desktop:~/workdir/snp-edk2$ > brijesh@sbrijesh-desktop:~/workdir/snp-edk2$ uncrustify --version > Uncrustify-0.69.0_f >=20 > I did submitted PR after above uncurstify run but the CI still didn't=20 > like it. Do we need to have specific version of uncrustify ? >=20 Reading through the "Add Uncrustify formatting overview" email it seems=20 we need to use a edk2 forked version of uncrustify [1]. With this now I=20 dont get any error. [1]=20 https://dev.azure.com/projectmu/Uncrustify/_packaging?_a=3Dpackage&feed=3Dm= u_uncrustify&package=3Dmu-uncrustify-release&version=3D73.0.3&protocolType= =3DNuGet thanks