From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 11 Apr 2019 10:52:22 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83083308620F; Thu, 11 Apr 2019 17:52:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-126-53.rdu2.redhat.com [10.10.126.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 152C05C207; Thu, 11 Apr 2019 17:52:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64 To: devel@edk2.groups.io, philmd@redhat.com, rebecca@bluestop.org, Liming Gao , Yonghong Zhu References: <20190411031653.38092-1-rebecca@bluestop.org> From: "Laszlo Ersek" Message-ID: <19000479-83f6-49fb-7a68-e09b31cd0a0e@redhat.com> Date: Thu, 11 Apr 2019 19:52:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 11 Apr 2019 17:52:21 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04/11/19 16:23, Philippe Mathieu-Daud=C3=A9 wrote: > On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: >> Some systems such as FreeBSD identify the platform as 'arm64' >> and not 'aarch64' as Linux does. >=20 > Per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220297 > this seems to be a FreeBSD bug. You are correct, but that issue was filed on 2017-06-26. I don't think we should hold our breaths, as long as the workaround is simple. And, it does look simple. (We've worked around worse.) I do suggest an addition to the patch, however: Rebecca, please add the link discovered by Phil near the "arm64" matches, in a comment. Something like: # work around Thanks, Laszlo >=20 >> Signed-off-by: Rebecca Cran >> --- >> BaseTools/Source/C/GNUmakefile | 5 +++-- >> BaseTools/Source/C/Makefiles/header.makefile | 5 +++-- >> 2 files changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/BaseTools/Source/C/GNUmakefile b/BaseTools/Source/C/GNUmak= efile >> index 1d048c4cc6..37bcce519c 100644 >> --- a/BaseTools/Source/C/GNUmakefile >> +++ b/BaseTools/Source/C/GNUmakefile >> @@ -21,8 +21,9 @@ ifndef HOST_ARCH >> endif >> ifneq (,$(findstring aarch64,$(uname_m))) >> HOST_ARCH=3DAARCH64 >> - endif >> - ifneq (,$(findstring arm,$(uname_m))) >> + else ifneq (,$(findstring arm64,$(uname_m))) >> + HOST_ARCH=3DAARCH64 >> + else ifneq (,$(findstring arm,$(uname_m))) >> HOST_ARCH=3DARM >> endif >> ifndef HOST_ARCH >> diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/S= ource/C/Makefiles/header.makefile >> index 90fb3453ad..d76b8283dd 100644 >> --- a/BaseTools/Source/C/Makefiles/header.makefile >> +++ b/BaseTools/Source/C/Makefiles/header.makefile >> @@ -23,8 +23,9 @@ ifndef HOST_ARCH >> endif >> ifneq (,$(findstring aarch64,$(uname_m))) >> HOST_ARCH=3DAARCH64 >> - endif >> - ifneq (,$(findstring arm,$(uname_m))) >> + else ifneq (,$(findstring arm64,$(uname_m))) >> + HOST_ARCH=3DAARCH64 >> + else ifneq (,$(findstring arm,$(uname_m))) >> HOST_ARCH=3DARM >> endif >> ifndef HOST_ARCH >> >=20 >=20 >=20