From: "John Chew" <yuinyee.chew@starfivetech.com>
To: Sunil V L <sunilvl@ventanamicro.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 6/6] StarFive/JH7110Pkg: Add JH7110 Silicon Package
Date: Fri, 20 Oct 2023 01:58:38 -0700 [thread overview]
Message-ID: <19195.1697792318298815792@groups.io> (raw)
In-Reply-To: <ZTEiXv6ca+xKHX7f@sunil-laptop>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Thu, Oct 19, 2023 at 08:34 PM, Sunil V L wrote:
>
> The patch should have commit message more than one liner. Same comment
> for PATCH 1/6 and 2/6
Hi Sunil,
Okay sure. I will remove the commented code.
Let me improve the commit message and include all maintainers in patch V2.
Thanks =)
John
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109829): https://edk2.groups.io/g/devel/message/109829
Mute This Topic: https://groups.io/mt/102053687/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1175 bytes --]
prev parent reply other threads:[~2023-10-20 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 2:59 [edk2-devel] [PATCH v1 1/6] StarFive/JH7110Pkg: Add Pci controller driver John Chew
2023-10-19 2:59 ` [edk2-devel] [PATCH v1 2/6] StarFive/JH7110Pkg: Add SPI protocol and driver support John Chew
2023-10-19 2:59 ` [edk2-devel] [PATCH v1 3/6] StarFive/JH7110Pkg: Add firmware volume block protocol John Chew
2023-10-19 2:59 ` [edk2-devel] [PATCH v1 4/6] StarFive/JH7110Pkg: Add PlatformBootManagerLib library John Chew
2023-10-19 12:12 ` Sunil V L
2023-10-20 9:34 ` John Chew
2023-10-19 2:59 ` [edk2-devel] [PATCH v1 5/6] StarFive/JH7110Pkg: Implement boot services memory allocation driver John Chew
2023-10-19 12:14 ` Sunil V L
2023-10-20 8:45 ` John Chew
2023-10-19 2:59 ` [edk2-devel] [PATCH v1 6/6] StarFive/JH7110Pkg: Add JH7110 Silicon Package John Chew
2023-10-19 12:34 ` Sunil V L
2023-10-20 8:58 ` John Chew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19195.1697792318298815792@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox