From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v2 0/8] Update EDKII Performance infrastructure based on ACPI FPDT table To: Dandan Bi ,devel@edk2.groups.io From: boonewang@zhaoxin.com X-Originating-Location: Xi'an, Shaanxi, CN (125.76.214.122) X-Originating-Platform: Windows Firefox 74 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Tue, 28 Apr 2020 00:45:21 -0700 References: <1517320437-11688-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1517320437-11688-1-git-send-email-dandan.bi@intel.com> Message-ID: <19337.1588059921800305707@groups.io> Content-Type: multipart/alternative; boundary="BJt7etqoUNhxThYfgs6z" --BJt7etqoUNhxThYfgs6z Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, Dandan I have seen an email named =E2=80=9C [edk2] [PATCH v2 8/8] ShellPkg/Dp: Up= dated to dump perf log based on FPDT table =E2=80=9C in mail-archive =E2=80= = =9D and I know there is an update of Dp. But I feel uncertain that: -=C2=A0 // Determine in which direction the performance counter counts. -= =C2=A0 TimerInfo.CountUp =3D (BOOLEAN) (TimerInfo.EndCount >=3D TimerInfo.= StartCount); +=C2=A0 TimerInfo.StartCount =3D 0; +=C2=A0 TimerInfo.EndCount= = =C2=A0=C2=A0 =3D 0xFFFF; +=C2=A0 TimerInfo.CountUp =3D TRUE; So it looks like we would not use timer count down feature , does it mean = we should use count up timer such as TSC or ACPI Timer? Maybe is there any = other cause? I am looking forward your reply! Thanks! --BJt7etqoUNhxThYfgs6z Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi, Dandan=

I have se= en an email named =E2=80=9C [edk2] [PATCH v2 8/8] = ShellPkg/Dp: Updated to dump perf log based on FPDT table =E2=80=9C<= span lang=3D"EN-US"> in mail-archive=E2=80=9D a= nd I know there is an update of Dp.

But I fee= l uncertain that:

-=C2=A0 // Determine in which direction the performance counter counts=
.
-=C2=A0 TimerInfo.CountUp =3D (BOOLEAN) (TimerInfo.EndCount >=3D Ti=
merInfo.StartCount);
+=C2=A0 TimerInfo.StartCount =3D 0;
+=C2=A0 TimerInfo.EndCount=C2=A0=C2=A0 =3D 0xFFFF;
+=C2=A0 TimerInfo.CountUp =3D TRUE;

So it loo= ks like we would not use timer count down feature, does it mean we s= hould use count up timer such as TSC or ACPI Timer? Maybe is there any othe= r cause?

=C2=A0

I am look= ing forward your reply! Thanks!

--BJt7etqoUNhxThYfgs6z--