From: Laszlo Ersek <lersek@redhat.com>
To: evan.lloyd@arm.com, edk2-devel@lists.01.org
Cc: "ard.biesheuvel@linaro.org"@arm.com,
"leif.lindholm@linaro.org"@arm.com,
"Matteo.Carlini@arm.com"@arm.com, "lersek@redhat.com"@arm.com,
"liming.gao@intel.com"@arm.com,
"michael.d.kinney@intel.com"@arm.com,
"jordan.l.justen@intel.com"@arm.com, "nd@arm.com"@arm.com
Subject: Re: [edk2-CCodingStandardsSpecification PATCH 4/5] Fix Chapter 4 Typo
Date: Wed, 3 Jan 2018 17:56:28 +0100 [thread overview]
Message-ID: <19488064-cdb2-083b-75a4-d2726e8773c0@redhat.com> (raw)
In-Reply-To: <20180103112248.11880-5-evan.lloyd@arm.com>
On 01/03/18 12:22, evan.lloyd@arm.com wrote:
> From: Evan Lloyd <evan.lloyd@arm.com>
>
> 4.1.3.2 - remove "See" from 'as specified in See "File Heading"'
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
> ---
> 4_naming_conventions/README.md | 418 ++++++++++----------
> 1 file changed, 209 insertions(+), 209 deletions(-)
Looks like this file underwent a line terminator conversion as well.
If the file is currently not using CRLF, then I agree it should be
converted; however, the conversion should be please separated from the
typo fix.
... Hmm, the file already seems to use CRLF. So I think the conversion
was to LF, and must have been unintended.
Can you please resubmit without the line terminator changes?
Thanks!
Laszlo
next prev parent reply other threads:[~2018-01-03 16:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 11:22 [edk2-CCodingStandardsSpecification PATCH 0/5] Typographic Corrections evan.lloyd
2018-01-03 11:22 ` [edk2-CCodingStandardsSpecification PATCH 1/5] Fix Chapter 1 Typos evan.lloyd
2018-01-03 16:51 ` Laszlo Ersek
2018-01-04 19:40 ` Evan Lloyd
2018-01-03 11:22 ` [edk2-CCodingStandardsSpecification PATCH 2/5] Fix Chapter 2 Typos evan.lloyd
2018-01-03 16:52 ` Laszlo Ersek
2018-01-03 11:22 ` [edk2-CCodingStandardsSpecification PATCH 3/5] Fix Chapter 3 Typos evan.lloyd
2018-01-03 16:53 ` Laszlo Ersek
2018-01-03 11:22 ` [edk2-CCodingStandardsSpecification PATCH 4/5] Fix Chapter 4 Typo evan.lloyd
2018-01-03 16:56 ` Laszlo Ersek [this message]
2018-01-08 18:31 ` Evan Lloyd
2018-01-03 11:22 ` [edk2-CCodingStandardsSpecification PATCH 5/5] Fix Chapter 5 Typos evan.lloyd
2018-01-03 17:07 ` Laszlo Ersek
2018-01-08 18:26 ` Evan Lloyd
-- strict thread matches above, loose matches on Subject: below --
2018-01-04 19:47 [edk2-CCodingStandardsSpecification PATCH 4/5] Fix Chapter 4 Typo Evan Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19488064-cdb2-083b-75a4-d2726e8773c0@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox