From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.29520.1595453155342118640 for ; Wed, 22 Jul 2020 14:25:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U4/lyfwG; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595453154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6ty/tHIzJMpF+nAntse0rJukhYv59le+ZePsIIxWsI=; b=U4/lyfwGrIM2crFW810LXZCxs6imhNfswtsNHdutTIXEzqfBDb9vj0UbkYj790LziH6s13 wGOrgq6bAbRK4kn9Jmi7VjAoVw3rtsYGpowpSYHnb4AmU/uv0JlOjM/3I/4hN3c6ycdMlZ 499jNrKXP62Z3dClQcOz+bumQEsj8qs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-2gH8YVSMM266VSegwb-29g-1; Wed, 22 Jul 2020 17:25:49 -0400 X-MC-Unique: 2gH8YVSMM266VSegwb-29g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB885106B242; Wed, 22 Jul 2020 21:25:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-129.ams2.redhat.com [10.36.113.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id D969D74F45; Wed, 22 Jul 2020 21:25:45 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v7 05/10] MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098) To: devel@edk2.groups.io, guomin.jiang@intel.com Cc: Jian J Wang , Hao A Wu , Dandan Bi , Liming Gao , Debkumar De , Harry Han , Catharine West References: <20200722083657.739-1-guomin.jiang@intel.com> <20200722083657.739-6-guomin.jiang@intel.com> From: "Laszlo Ersek" Message-ID: <194a11be-ce86-a840-3717-1b8d2e3874d0@redhat.com> Date: Wed, 22 Jul 2020 23:25:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200722083657.739-6-guomin.jiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/22/20 10:36, Guomin Jiang wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > When we allocate pool to save the rebased PEIMs, the address will change > randomly, therefore the hash will change and result PCR0 change as well. > To avoid this, we save the raw PEIMs and use it to calculate hash. > > The MigratedFvInfo HOB will never produce when > PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control > the total feature. > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > Cc: Debkumar De > Cc: Harry Han > Cc: Catharine West > Signed-off-by: Guomin Jiang > Acked-by: Laszlo Ersek > Reviewed-by: Jian J Wang > --- > MdeModulePkg/MdeModulePkg.dec | 3 ++ > MdeModulePkg/Core/Pei/PeiMain.inf | 1 + > MdeModulePkg/Core/Pei/PeiMain.h | 1 + > MdeModulePkg/Include/Guid/MigratedFvInfo.h | 22 +++++++++++++++ > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 28 +++++++++++++++++++ > 5 files changed, 55 insertions(+) > create mode 100644 MdeModulePkg/Include/Guid/MigratedFvInfo.h Comment fixes only (relative to v5); my A-b stands. Laszlo