From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 44B66D8108F for ; Thu, 2 Nov 2023 10:56:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=E8UlOvpySeO8YQPiOe9PADs4b55lfgewpD1f7gS2Yj0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698922610; v=1; b=EUOfLU5yPv5y0QkcBaVL+fuFnpQpMECVNqdNhoZh0JtJ1H3Hnw+apJbrHTlH/KmFhkyz/uJw KnmDYZx//htOPVw+U9Vv+kuIEEGc2f8t8/hMUReAdBeU3pw/IroYf0xGcFgCp1lf7vMJ0fXom+x TjqT+Vj7tkk6y/ikfCL/0rUw= X-Received: by 127.0.0.2 with SMTP id JK9jYY7687511xgtvhgq0CDz; Thu, 02 Nov 2023 03:56:50 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.28255.1698922610156861929 for ; Thu, 02 Nov 2023 03:56:50 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28--7KE3wvKM8mjDC9UfmBhsg-1; Thu, 02 Nov 2023 06:56:47 -0400 X-MC-Unique: -7KE3wvKM8mjDC9UfmBhsg-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58F043C40B4A; Thu, 2 Nov 2023 10:56:47 +0000 (UTC) X-Received: from [10.39.195.76] (unknown [10.39.195.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EBED25A7; Thu, 2 Nov 2023 10:56:45 +0000 (UTC) Message-ID: <19653d30-e63a-573a-eb88-bbcf91558ca5@redhat.com> Date: Thu, 2 Nov 2023 11:56:44 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to allow whitespace issues in .rtf files To: devel@edk2.groups.io, rebecca@bsdio.com, Liming Gao , Bob Feng , Yuwei Chen References: <20231102002052.17494-1-rebecca@bsdio.com> From: "Laszlo Ersek" In-Reply-To: <20231102002052.17494-1-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: svwApFCTAAu9F2n4b5es8Yuyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EUOfLU5y; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 11/2/23 01:20, Rebecca Cran wrote: > Allow .rtf files created by applications such as Notepad to be committed > as-is without further manual editing by skipping the requirements for > CRLF, no tabs and no trailing whitespace. >=20 > Signed-off-by: Rebecca Cran > --- > BaseTools/Scripts/PatchCheck.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchChe= ck.py > index 900226f18fe5..7f372d40b570 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -363,6 +363,9 @@ class GitDiffCheck: > self.is_newfile =3D False > self.force_crlf =3D True > self.force_notabs =3D True > + if self.filename.endswith('.rtf'): > + self.force_crlf =3D False > + self.force_notabs =3D False > if self.filename.endswith('.sh') or \ > self.filename.startswith('BaseTools/BinWrappers/Posi= xLike/') or \ > self.filename.startswith('BaseTools/BinPipWrappers/P= osixLike/') or \ > @@ -416,7 +419,7 @@ class GitDiffCheck: > self.format_error("didn't find diff hunk marker (@@)= ") > self.line_num +=3D 1 > elif self.state =3D=3D PATCH: > - if self.binary: > + if self.binary or self.filename.endswith(".rtf"): > pass > elif line.startswith('-'): > pass superficially Acked-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110521): https://edk2.groups.io/g/devel/message/110521 Mute This Topic: https://groups.io/mt/102332684/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-