Re: [edk2-devel] [PATCH v1 0/4] UncrustifyCheck Ignore Support

["Michael Kubacki" <mikuback@linux.microsoft.com>]

I made it one series since the OvmfPkg patches are dependent on the 
.pytool changes.

Let me know if you see a substantial advantage to split it up.

Regards,
Michael

On 3/22/2022 12:14 PM, Michael D Kinney wrote:
> Hi Michael,
> 
> Should this be broken up into 2 series?  One for pytool change and one for OvmfPkg?
> 
> Mike
> 
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Monday, March 21, 2022 6:58 PM
>> To: devel@edk2.groups.io
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Sean Brogan
>> <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
>> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Rebecca Cran
>> <rebecca@bsdio.com>; Peter Grehan <grehan@freebsd.org>; Laszlo Ersek <lersek@redhat.com>
>> Subject: [PATCH v1 0/4] UncrustifyCheck Ignore Support
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>>
>> This patch series:
>> 1. Updates ignore handling in UncrustifyCheck including adding
>> a new CI plugin configuration option to ignore files in a package.
>> 2. Reverts Uncrustify changes as requested for files in OvmfPkg.
>> 3. Uses the new ignore file option to ignore the files that had
>> Uncrustify formatting reverted in OvmfPkg.
>>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Peter Grehan <grehan@freebsd.org>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (4):
>>    .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths
>>    .pytool/Plugin/UncrustifyCheck: Add ignore file support
>>    OvmfPkg: Revert Uncrustify formatting in VbeShim.h files
>>    OvmfPkg: Do not check VbeShim.h formatting with Uncrustify
>>
>>   .pytool/Plugin/UncrustifyCheck/Readme.md          |    7 +
>>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py |   30 +-
>>   OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h               | 1811 ++++++++++----------
>>   OvmfPkg/OvmfPkg.ci.yaml                           |    5 +
>>   OvmfPkg/QemuVideoDxe/VbeShim.h                    | 1389 ++++++++-------
>>   5 files changed, 1640 insertions(+), 1602 deletions(-)
>>
>> --
>> 2.28.0.windows.1
> 
> 
> 
> 
> 
>