From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.723.1648829049684050822 for ; Fri, 01 Apr 2022 09:04:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=nryhsHKW; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id A765920DEED1; Fri, 1 Apr 2022 09:04:07 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A765920DEED1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1648829049; bh=tVAwqzNy7iyxTQzkN9oXf6FRrejFtc9NvjjW6NIC7A0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nryhsHKWhq8AYSntFivUCJrXMLPVwAyORuj0J1yM/Isvk54HZNCRSK4siFMFM1iwE cHN9pSvLQA57i9C5xmk3Y/HjmaH8svZlM0UIXp54ltrIMpNVFdsqpYC/5FedxxE1K7 aHNjNeQSxvb7+VyfM/YCmBpcW44mdoWSOgznEDZI= Message-ID: <197f126a-76b9-8437-9eb1-e92e570779e1@linux.microsoft.com> Date: Fri, 1 Apr 2022 12:04:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [PATCH v1 0/4] UncrustifyCheck Ignore Support To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Gao, Liming" , Sean Brogan , Bret Barkelew , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" , Gerd Hoffmann , Rebecca Cran , Peter Grehan , Laszlo Ersek References: <20220322015814.9182-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I made it one series since the OvmfPkg patches are dependent on the .pytool changes. Let me know if you see a substantial advantage to split it up. Regards, Michael On 3/22/2022 12:14 PM, Michael D Kinney wrote: > Hi Michael, > > Should this be broken up into 2 series? One for pytool change and one for OvmfPkg? > > Mike > >> -----Original Message----- >> From: mikuback@linux.microsoft.com >> Sent: Monday, March 21, 2022 6:58 PM >> To: devel@edk2.groups.io >> Cc: Kinney, Michael D ; Gao, Liming ; Sean Brogan >> ; Bret Barkelew ; Ard Biesheuvel ; Yao, Jiewen >> ; Justen, Jordan L ; Gerd Hoffmann ; Rebecca Cran >> ; Peter Grehan ; Laszlo Ersek >> Subject: [PATCH v1 0/4] UncrustifyCheck Ignore Support >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880 >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875 >> >> This patch series: >> 1. Updates ignore handling in UncrustifyCheck including adding >> a new CI plugin configuration option to ignore files in a package. >> 2. Reverts Uncrustify changes as requested for files in OvmfPkg. >> 3. Uses the new ignore file option to ignore the files that had >> Uncrustify formatting reverted in OvmfPkg. >> >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Sean Brogan >> Cc: Bret Barkelew >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Gerd Hoffmann >> Cc: Rebecca Cran >> Cc: Peter Grehan >> Cc: Laszlo Ersek >> Signed-off-by: Michael Kubacki >> >> Michael Kubacki (4): >> .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths >> .pytool/Plugin/UncrustifyCheck: Add ignore file support >> OvmfPkg: Revert Uncrustify formatting in VbeShim.h files >> OvmfPkg: Do not check VbeShim.h formatting with Uncrustify >> >> .pytool/Plugin/UncrustifyCheck/Readme.md | 7 + >> .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 30 +- >> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h | 1811 ++++++++++---------- >> OvmfPkg/OvmfPkg.ci.yaml | 5 + >> OvmfPkg/QemuVideoDxe/VbeShim.h | 1389 ++++++++------- >> 5 files changed, 1640 insertions(+), 1602 deletions(-) >> >> -- >> 2.28.0.windows.1 > > > > > >